Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-2908 Markdown Armstrong Number Exercise #2630

Merged
merged 1 commit into from
Jul 10, 2024
Merged

CON-2908 Markdown Armstrong Number Exercise #2630

merged 1 commit into from
Jul 10, 2024

Conversation

zanninso
Copy link
Contributor

@zanninso zanninso commented Jul 3, 2024 •
edited by jira bot
Loading

@zanninso zanninso requested a review from MSilva95 July 3, 2024 02:32
@zanninso zanninso self-assigned this Jul 3, 2024
MSilva95
MSilva95 requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format, and it's good to go.
Again, I'm not a fan of all those comments in the usage, for example why would we leave comments like " // Expected output: true " if we actually have the expected output below?

@zanninso zanninso requested a review from MSilva95 July 8, 2024 00:46
@HarryVasanth HarryVasanth changed the title CON-2908-Markdown-Armstrong-Number-Exercise CON-2908 Markdown Armstrong Number Exercise Jul 8, 2024
@HarryVasanth HarryVasanth added the 🗂️ docs Documentation label Jul 8, 2024
MSilva95
MSilva95 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
You can close the conversation if you feel no need to format the runner.java

@zanninso zanninso merged commit 0b0d423 into master Jul 10, 2024
5 checks passed
@zanninso zanninso deleted the CON-2908-Markdown-Armstrong-Number-Exercise branch July 10, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSilva95 MSilva95 MSilva95 approved these changes

Assignees

@zanninso zanninso

Labels
🗂️ docs Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanninso @MSilva95 @HarryVasanth