Skip to content

Commit

Permalink
Merge branch 'master' into patch-6
Browse files Browse the repository at this point in the history
  • Loading branch information
HarryVasanth authored Oct 30, 2024
2 parents 8fa15df + b54465c commit fa5a651
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion subjects/get-them-all-dom/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
You've been attributed the task to find the main architect of the Tower of Pisa before he achieves his plans, avoiding us nowadays all those lame pictures of people pretending to stop it from falling.

You arrive at the architects' chamber to find him, but all you have in front of you is a bunch of unknown people.
Step by step, with the little information you have, gather information and figure out by elimination who he is.
Step by step, with the limited details you have, gather information and figure out by elimination who he is.

Launch the provided HTML file in the browser to begin your investigation.<br/>
On top of the webpage, each of the four buttons fires a function:
Expand Down
2 changes: 1 addition & 1 deletion subjects/get-them-all/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
You've been attributed the task to find the main architect of the Tower of Pisa before he achieves his plans, avoiding us nowadays all those lame pictures of people pretending to stop it from falling.

You arrive at the architects' chamber to find him, but all you have in front of you is a bunch of unknown people.
Step by step, with the little information you have, gather information and figure out by elimination who he is.
Step by step, with the limited details you have, gather information and figure out by elimination who he is.

Launch the provided HTML file in the browser to begin your investigation.<br/>
On top of the webpage, each of the four buttons fires a function:
Expand Down
2 changes: 1 addition & 1 deletion subjects/its-a-match/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

### Instructions

Have you been pondering over the etymology of `grep`?
Have you ever pondered the etymology of `grep`?

Create 4 regular expression variables:

Expand Down
17 changes: 9 additions & 8 deletions subjects/sortable/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,20 @@ We've found _confidential_ information about those superheroes.
You must write all of the code from scratch. You are not allowed to rely on any frameworks or libraries like React, Vue, Svelte etc.

#### Fetching the data

In order to get the information, you should use `fetch`.
When you use `fetch` in JS, it always returns a `Promise`. We will look more deeply into that later on. For now, tak a look at this:
When you use `fetch` in JS, it always returns a `Promise`. We will look more deeply into that later on. For now, take a look at this:

```js
// This function is called only after the data has been fetched, and parsed.
const loadData = heroes => {
console.log(heroes)
}
const loadData = (heroes) => {
console.log(heroes);
};

// Request the file with fetch, the data will downloaded to your browser cache.
fetch('https://rawcdn.githack.com/akabab/superhero-api/0.2.0/api/all.json')
// Request the file with fetch, and the data will be downloaded to your browser cache.
fetch("https://rawcdn.githack.com/akabab/superhero-api/0.2.0/api/all.json")
.then((response) => response.json()) // parse the response from JSON
.then(loadData) // .then will call the `loadData` function with the JSON value.
.then(loadData); // .then will call the `loadData` function with the JSON value.
```

#### Display
Expand Down Expand Up @@ -73,7 +74,7 @@ Additional features will be critical to your success. Here's a few which will gi
- `include`
- `exclude`
- `fuzzy`
- `equal`, `not equal`, `greater than` and `lesser than` for numbers (including weight and height).
- `equal`, `not equal`, `greater than` and `lesser than` for numbers (including weight and height).
- Detail view. Clicking a hero from the list will show all the details and large image.
- A slick design. Spend some time improving the look and feel by playing around with CSS. Have fun with it.
- Modify the URL with the search term, so that if you copy and paste the URL in a different tab, it will display the same column filters. If you have implemented detail view, the state of which hero is displayed should also form part of the URL.

0 comments on commit fa5a651

Please sign in to comment.