Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ascii #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ascii #65

wants to merge 3 commits into from

Conversation

eslopfer
Copy link
Contributor

Add tests and solution for ascii subject.

@eslopfer eslopfer linked an issue Jun 23, 2022 that may be closed by this pull request
ascii 01-edu/public#1266
Closed
zainabdnaya
zainabdnaya approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@zainabdnaya zainabdnaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works well

@eslopfer eslopfer requested review from davhojt and MSilva95 June 24, 2022 09:44
MSilva95
MSilva95 requested changes Jun 24, 2022
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good exercise but im not sure if this one is going to the exam because the studens are not used to bytes @davhojt needs to see this one.

tests/ascii_test/main.go Show resolved Hide resolved
@davhojt davhojt removed their request for review September 19, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSilva95 MSilva95 MSilva95 requested changes

@zainabdnaya zainabdnaya zainabdnaya approved these changes

@Hamzaelkhatri Hamzaelkhatri Hamzaelkhatri approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ascii
4 participants
@eslopfer @Hamzaelkhatri @zainabdnaya @MSilva95