Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-2661 [CHECKPOINT-RESTRUCTURE] Make gcd solution a function instead of a program #184

Merged
merged 1 commit into from
Jun 27, 2024
Merged

CON-2661 [CHECKPOINT-RESTRUCTURE] Make gcd solution a function instead of a program #184

merged 1 commit into from
Jun 27, 2024

Conversation

nprimo
Copy link
Contributor

@nprimo nprimo commented Apr 29, 2024

  • update tests accordingly

@nprimo nprimo self-assigned this Apr 29, 2024
@nprimo nprimo requested a review from MSilva95 June 3, 2024 14:10
MSilva95
MSilva95 requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is not responding when we give wrong solutions

tests/gcd_test/main.go Show resolved Hide resolved
MSilva95
MSilva95 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HarryVasanth HarryVasanth changed the title CON-2661 make gcd solution a function instead of a program CON-2661 [CHECKPOINT-RESTRUCTURE] Make gcd solution a function instead of a program Jun 25, 2024
HarryVasanth
HarryVasanth approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@HarryVasanth HarryVasanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

✅ Production and pre-production prerequisites have been deployed.

Clear to merge!

@HarryVasanth HarryVasanth merged commit 52b72ff into master Jun 27, 2024
1 check passed
@HarryVasanth HarryVasanth deleted the CON-2661-update-gcd-test-and-solution branch June 27, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSilva95 MSilva95 MSilva95 approved these changes

@HarryVasanth HarryVasanth HarryVasanth approved these changes

Assignees

@nprimo nprimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nprimo @HarryVasanth @MSilva95