Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-2639 exercise findspairs #182

Merged
merged 7 commits into from
May 10, 2024

Conversation

MSilva95
Copy link
Member

CON-2639

exercise findspairs test and sol

@MSilva95 MSilva95 self-assigned this Apr 22, 2024
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments with the diff that I feel should be applied to make the test vs an expected result using a "custom" function (runStudentProgram) instead of running our solution vs the student one. If the print should have a new line we should update all the want testCases to have \n at the end :)

There were some "weird" test cases as well.

solutions/findpairs/main.go Show resolved Hide resolved
tests/findpairs_test/main.go Show resolved Hide resolved
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current tests are not passing with the provided solution - I have added some possible solutions in the comments :)

solutions/findpairs/main.go Show resolved Hide resolved
tests/findpairs_test/main.go Show resolved Hide resolved
solutions/findpairs/main.go Outdated Show resolved Hide resolved
solutions/findpairs/main.go Show resolved Hide resolved
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just a small formatting difference between the current solution and the expected one from the tests :)
I left a comment inline

solutions/findpairs/main.go Outdated Show resolved Hide resolved
@MSilva95 MSilva95 requested a review from nprimo May 8, 2024 17:04
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@MSilva95 MSilva95 merged commit 56c3534 into master May 10, 2024
1 check passed
@MSilva95 MSilva95 deleted the CON-2639-exercise-findspairs-test-and-sol branch May 10, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants