-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include cumulative fixes from jdom-2.0.x branch #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rence to latest 1.1.4
COde was trying to be too clever about value duplication. As a result, the enumberator values were trying to reference each other before they were initialized. Fix is to just do things simpler. Much simpler.
…test class so may not be desirable for permanent inclusion)
…content outside the root element. Not able to reproduce with my StAX libraries, but the fix is 'safe'.
StAX is a *poor* specification, and the default implementations of StAX are broken too.
…now variables)
Now it does a Copy-Constructor clone instead of changing final instance fields.
…st case to 2.x anyway - even though code works.
conflict. Make JDOM sort methods public.
Originally the enum would initialize all three factories on firs use. Now the initialization will happen on a per-factory basis. It is still a lazy singleton concept. On my computer this saves as much as 200ms on JDOM startup
JDOM 1.x managed to handle badly-built DOM documents that had implied namespaces in place.
Report prolog whitespace - allow the Document level content to include whitespace, not just Doctype, root element, comments, PI's, etc.
sources jar in maven central.
All character encodings are required to be specified with ASCII names, making the ENGLISH locale appropreiate.
…o upper level supplier
Conflicts: core/src/java/org/jdom2/input/StAXStreamBuilder.java core/src/java/org/jdom2/input/sax/TextBuffer.java core/src/java/org/jdom2/output/support/AbstractStAXStreamProcessor.java
…t when flushing chars
Also includes test case for #173 that was missed in previous commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of these commits were merged in to both jdom-2.0.x branch and also master. Makes this PR look larger than it actually is.
I pulled both the jdom-2.0.x and master branch in to tmp-cleanup in order to untangle some conflicts. The result should be a clean combination back in to master branch.
jdom-2.0.x branch should be decommissioned after this is merged.