Fixes #161 - Made sure we set the parent if it where not set. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Appreciate the fix. Code in "contrib" area is not rigorously tested (and not even distributed) like the core JDOM. It would be great if you could give feedback on whether the ElementScanner class is working well for you (with the fix). |
|
Will merge this later (needs to be merged in to both branches master, and jdom2.0.x) |
|
Yes the ElementScanner is working nicely for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the ElementScanner#parse(InputSource) so it will not throw a NullPointer Exception when the parent XMLReader was not set.