Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.net core 3.0 preview 7 #501

Closed
dotnetshadow opened this issue Jul 27, 2019 · 14 comments
Closed

.net core 3.0 preview 7 #501

dotnetshadow opened this issue Jul 27, 2019 · 14 comments
Assignees

Comments

@dotnetshadow
Copy link

dotnetshadow commented Jul 27, 2019

Description

A few errors when trying to use version 2.0.7

I had to manually reference
<PackageReference Include="Remotion.Linq" Version="2.2.0" />

Query trying to run:

var cashQuery = _context.Transactions.AsNoTracking().Where(x => x.Id== Id).DeferredSum(x => x.Amount).FutureValue<decimal>();

Exception

FileNotFoundException: Could not load file or assembly 'Remotion.Linq, Version=2.1.0.0, Culture=neutral, PublicKeyToken=fee00910d6e5f53b'. The system cannot find the file specified.

Once I got past that and tried to run something I got the following:
InvalidCastException: Unable to cast object of type 'Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryable1[System.Decimal]' to type 'Remotion.Linq.QueryableBase1[System.Decimal]'.

Further technical details

  • EF version: 3.0 preview7
  • EF Plus version: 2.0.7
  • Database Provider: sql server 2016
@JonathanMagnan JonathanMagnan self-assigned this Jul 27, 2019
@JonathanMagnan
Copy link
Member

Hello @dotnetshadow ,

At this moment, we only support EF version 3.0 preview5: https://www.nuget.org/packages/Z.EntityFramework.Plus.EFCore/3.0.7-preview5

However, we have made a major progress to be able to support preview7 last week (a lot of internal code we were used was modified).

So at this moment, we still doesn't support the preview7 but we highly believe that we will be able to release a new version next week that support it.

I will keep you updated.

Best Regards,

Jonathan

@dotnetshadow
Copy link
Author

Great to hear, thanks for your prompt response

@dotnetshadow
Copy link
Author

Any luck with getting this to work?

@JonathanMagnan
Copy link
Member

Hello @dotnetshadow ,

We do our best, but unfortunately, it has been WAY harder than we thought.

At this moment, we are currently cleaning up all the code to see if we can find another issue.

Only the Query IncludeFilter feature doesn't work on our side due to this issue: dotnet/efcore#17150

It looks that we cannot do anymore some basic SelectMany. We will wait for the official answer from the EF team since I believe that's an issue on their side that they will fix.

If everything goes well during our cleanup, we might release a version with the preview 8 but throw a temporary error for the IncludeFilter features explaining the situation.

@dotnetshadow
Copy link
Author

Thank you for all your efforts, much appreciated
It seems the EF team might of fixed your issue with the current daily build?

@JonathanMagnan
Copy link
Member

Yup it's probably fixed on their daily build

We will test it tomorrow and use a temporary try/catch and explain the situation in the catch about the daily build.

Anyway, we already have planned to make a release for next Monday (with or without IncludeFilter) if no more issue is found.

One of my developers is at this moment testing all our latest changes.

@JonathanMagnan
Copy link
Member

Hello @dotnetshadow ,

The 3.0.8-preview8 has been released. As specified, this version throws an error for the IncludeFilter temporary. However, all other features should work.

Be careful, this version has now a dependency on Z.EntityFramework.Extensions. We will make an announcement about it this week.

Even if EF Extensions is a commercial library, features inside EF Plus stay 100% free, so don't worry with this.

@dotnetshadow
Copy link
Author

@JonathanMagnan Thank you so much for your prompt build.

I will give it a go this week and report back if I find any issues.

@dotnetshadow
Copy link
Author

@JonathanMagnan just updated to 3.0.8-preview8 and working well for me great job.
Thanks, appreciate your efforts

@OzBob
Copy link

OzBob commented Sep 2, 2019

Have you seen the long running open EFcore issue (dotnet/efcore#1833 (comment)) on EF core about not having a native IncludeFilter.

Have you considered pulling together a merge request of EF+ into EF Core?

@JonathanMagnan
Copy link
Member

Hello @OzBob ,

The goal of a third party library is to offer features the main library doesn't offer.

If they still have added the feature on their side, they probably got their reason.

@OzBob
Copy link

OzBob commented Sep 2, 2019

Fair comment. Thanks for replying and for doing a great job on EF+.

@JonathanMagnan
Copy link
Member

Hello,

We will close this issue, if you want to follow about when preview-9 will be available I guess you can follow this issue: #515

We should work on it during the weekend.

Best Regards,

Jonathan

@JonathanMagnan
Copy link
Member

FYI: The v3.0.9-preview9-01 has been released.

The IncludeFilter is now back ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants