Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linting warnings/errors #1

Closed
zzkt opened this issue Jul 30, 2022 · 1 comment
Closed

fix linting warnings/errors #1

zzkt opened this issue Jul 30, 2022 · 1 comment

Comments

@zzkt
Copy link
Owner

zzkt commented Jul 30, 2022

[00:00.106]  sclang-browser.el:156: Second line should not have indentation
[00:00.106]  sclang-browser.el:156: First line is not a complete sentence
[00:00.106]  sclang-browser.el:156: First line should be capitalized
[00:00.106]  sclang-browser.el:156: Argument ‘buffer-name’ should appear (as BUFFER-NAME) in the doc string
[00:00.107]  Found 15 warnings in file ‘sclang-browser.el’

[00:00.150]  sclang-help.el:192: You should convert this comment to documentation
[00:00.152]  sclang-help.el:351: You should convert this comment to documentation
[00:00.154]  sclang-help.el:460: Argument ‘full’ should appear (as FULL) in the doc string
[00:00.156]  sclang-help.el:566: First sentence should end with punctuation
[00:00.156]  sclang-help.el:596: All interactive functions should have documentation
[00:00.156]  sclang-help.el:630: First sentence should end with punctuation
[00:00.157]  sclang-help.el:647: First sentence should end with punctuation
[00:00.157]  sclang-help.el:647: Argument ‘topic’ should appear (as TOPIC) in the doc string
[00:00.159]  Found 33 warnings in file ‘sclang-help.el’

[00:00.177]  sclang-interp.el:384: Second line should not have indentation
[00:00.177]  sclang-interp.el:384: First line is not a complete sentence
[00:00.179]  sclang-interp.el:478: Argument ‘fun’ should appear (as FUN) in the doc string
[00:00.179]  sclang-interp.el:485: Argument ‘fun’ should appear (as FUN) in the doc string
[00:00.180]  sclang-interp.el:495: Argument ‘arg’ should appear (as ARG) in the doc string
[00:00.180]  sclang-interp.el:539: First line is not a complete sentence
[00:00.181]  sclang-interp.el:540: There should be two spaces after a period
[00:00.181]  sclang-interp.el:546: Argument ‘silent-p’ should appear (as SILENT-P) in the doc string
[00:00.181]  sclang-interp.el:551: Argument ‘silent-p’ should appear (as SILENT-P) in the doc string
[00:00.181]  sclang-interp.el:562: Argument ‘silent-p’ should appear (as SILENT-P) in the doc string
[00:00.182]  sclang-interp.el:582: Argument ‘silent-p’ should appear (as SILENT-P) in the doc string
[00:00.183]  sclang-interp.el:598: Name lisp should appear capitalized as Lisp
[00:00.186]  Found 40 warnings in file ‘sclang-interp.el’

[00:00.198]  sclang-keys.el:43: All interactive functions should have documentation
[00:00.198]  Found 1 warning in file ‘sclang-keys.el’

[00:00.213]  sclang-language.el:208: There should be two spaces after a period
[00:00.214]  sclang-language.el:291: Lisp symbol ‘font-lock-mode’ should appear in quotes
[00:00.217]  sclang-language.el:643: First line should be capitalized
[00:00.217]  sclang-language.el:643: There should be two spaces after a period
[00:00.218]  sclang-language.el:711: Argument ‘name’ should appear (as NAME) in the doc string
[00:00.219]  sclang-language.el:748: Second line should not have indentation
[00:00.219]  sclang-language.el:748: First line should be capitalized
[00:00.219]  sclang-language.el:748: Argument ‘string’ should appear (as STRING) in the doc string
[00:00.221]  Found 27 warnings in file ‘sclang-language.el’

[00:00.247]  sclang-minor-mode.el:37: Keycode C-c embedded in doc string.  Use \\<mapvar> & \\[command] instead
[00:00.247]  sclang-minor-mode.el:61: Keycode C-c embedded in doc string.  Use \\<mapvar> & \\[command] instead
[00:00.248]  Found 3 warnings in file ‘sclang-minor-mode.el’

[00:00.261]  sclang-mode.el:122: You should convert this comment to documentation
[00:00.263]  sclang-mode.el:355: Argument ‘parse-start’ should appear (as PARSE-START) in the doc string
[00:00.270]  Found 27 warnings in file ‘sclang-mode.el’

[00:00.284]  sclang-server.el:93: Argument ‘event’ should appear (as EVENT) in the doc string
[00:00.285]  sclang-server.el:122: Argument ‘map’ should appear (as MAP) in the doc string
[00:00.287]  sclang-server.el:227: Argument ‘code’ should appear (as CODE) in the doc string
[00:00.287]  sclang-server.el:235: Argument ‘path’ should appear (as PATH) in the doc string
[00:00.288]  sclang-server.el:257: Argument ‘lat’ should appear (as LAT) in the doc string
[00:00.289]  Found 13 warnings in file ‘sclang-server.el’

[00:00.301]  sclang-util.el:40: Argument ‘str’ should appear (as STR) in the doc string
[00:00.301]  sclang-util.el:47: Argument ‘n’ should appear (as N) in the doc string
[00:00.302]  Found 6 warnings in file ‘sclang-util.el’

[00:00.317]  Found 3 warnings in file ‘sclang-widgets.el’

[00:00.329]  sclang.el:32: There should be two spaces after a period
[00:00.330]  Found 1 warning in file ‘sclang.el’

[00:00.531]  sclang-help.el:118:1: warning: `eval-after-load' is for use in configurations, and should rarely be used in packages.
[00:00.531]  sclang-help.el:310:8: warning: Closing parens should not be wrapped onto new lines.
[00:00.531]  Found 17 warnings in file ‘sclang-help.el’

[00:00.542]  sclang-interp.el:360:4: warning: Closing parens should not be wrapped onto new lines.
[00:00.542]  Found 1 warning in file ‘sclang-interp.el’

[00:00.554]  sclang-language.el:732:0: error: "false" doesn't start with package's prefix "sclang".
[00:00.554]  Found 1 warning in file ‘sclang-language.el’

[00:00.567]  sclang-mode.el:119:5: warning: Closing parens should not be wrapped onto new lines.
[00:00.567]  sclang-mode.el:145:58: error: This key sequence is reserved (see Key Binding Conventions in the Emacs Lisp manual)
[00:00.567]  sclang-mode.el:148:73: error: This key sequence is reserved (see Key Binding Conventions in the Emacs Lisp manual)
[00:00.567]  sclang-mode.el:298:5: warning: Closing parens should not be wrapped onto new lines.
[00:00.567]  sclang-mode.el:310:3: warning: Closing parens should not be wrapped onto new lines.
[00:00.567]  sclang-mode.el:604:11: warning: Closing parens should not be wrapped onto new lines.
[00:00.567]  Found 6 warnings in file ‘sclang-mode.el’

[00:00.575]  sclang.el:56:0: error: Customization groups should not end in "-mode" unless that name would conflict with their parent group.
[00:00.575]  Found 1 warning in file ‘sclang.el’

...and regexps

[00:00.587]  sclang-help.el:450:18: Ineffective string escape ‘\.’
[00:00.587]  sclang-help.el:450:25: Ineffective string escape ‘\.’
[00:00.587]  sclang-help.el:450:27: Ineffective string escape ‘\.’
[00:00.587]  sclang-help.el:450:42: Ineffective string escape ‘\.’
[00:00.587]  sclang-help.el:678:40: In add-to-list: Use \' instead of $ in file-matching regexp (pos 5)
               "\\.rtf$"
                ......^
[00:00.587]  Found 5 warnings in file ‘sclang-help.el’
[00:00.588]  sclang-interp.el:47:54: Ineffective string escape ‘\+’
[00:00.588]  sclang-interp.el:47:81: Ineffective string escape ‘\+’
[00:00.588]  sclang-interp.el:47:100: Ineffective string escape ‘\+’
[00:00.588]  Found 3 warnings in file ‘sclang-interp.el’
[00:00.591]  sclang-language.el:63:9: In sclang-method-name-special-chars: Repetition of repetition (pos 5)
               "-!%&*+/<=>?@|"
                .....^
[00:00.591]  sclang-language.el:71:3: In sclang-method-name-special-regexp: Duplicated ‘\’ inside character alternative (pos 7)
               "[-!%&\\*\\+/<=>\\?@|]+"
                ........^
[00:00.591]  sclang-language.el:71:3: In sclang-method-name-special-regexp: Duplicated ‘\’ inside character alternative (pos 13)
               "[-!%&\\*\\+/<=>\\?@|]+"
                ...............^
[00:00.591]  sclang-language.el:72:8: Value from ‘regexp-quote’ cannot be spliced into ‘[...]’
[00:00.591]  sclang-language.el:76:3: In sclang-method-name-regexp: Duplicated ‘\’ inside character alternative (pos 11)
               "\\(?:[-!%&\\*\\+/<=>\\?@|]+\\)\\|\\(?:[a-zA-Z]\\(?:\\sw\\|\\s_\\)*_?\\)"
                .............^
[00:00.591]  sclang-language.el:76:3: In sclang-method-name-regexp: Duplicated ‘\’ inside character alternative (pos 17)
               "\\(?:[-!%&\\*\\+/<=>\\?@|]+\\)\\|\\(?:[a-zA-Z]\\(?:\\sw\\|\\s_\\)*_?\\)"
                ....................^
[00:00.591]  sclang-language.el:90:3: In sclang-symbol-name-regexp: Duplicated ‘\’ inside character alternative (pos 15)
               "\\(?:\\(?:[-!%&\\*\\+/<=>\\?@|]+\\)\\|\\(?:[a-zA-Z]\\(?:\\sw\\|\\s_\\)*_?\\)\\)\\|\\(?:\\<\\(?:Meta_\\)?[A-Z]\\(?:\\sw\\|\\s_\\)*\\)"
                ..................^
[00:00.591]  sclang-language.el:90:3: In sclang-symbol-name-regexp: Duplicated ‘\’ inside character alternative (pos 21)
               "\\(?:\\(?:[-!%&\\*\\+/<=>\\?@|]+\\)\\|\\(?:[a-zA-Z]\\(?:\\sw\\|\\s_\\)*_?\\)\\)\\|\\(?:\\<\\(?:Meta_\\)?[A-Z]\\(?:\\sw\\|\\s_\\)*\\)"
                .........................^
[00:00.591]  sclang-language.el:104:3: In sclang-method-definition-regexp: Duplicated ‘\’ inside character alternative (pos 21)
               "^\\s *\\*?\\(\\(?:[-!%&\\*\\+/<=>\\?@|]+\\)\\|\\(?:[a-zA-Z]\\(?:\\sw\\|\\s_\\)*_?\\)\\)\\s *{"
                ..........................^
[00:00.591]  sclang-language.el:104:3: In sclang-method-definition-regexp: Duplicated ‘\’ inside character alternative (pos 27)
               "^\\s *\\*?\\(\\(?:[-!%&\\*\\+/<=>\\?@|]+\\)\\|\\(?:[a-zA-Z]\\(?:\\sw\\|\\s_\\)*_?\\)\\)\\s *{"
                .................................^
[00:00.591]  sclang-language.el:108:29: In sclang-block-regexp: Repetition subsumes preceding repetition (pos 21)
               "^\\((\\)\\s *\\(?:/[/*]?.*\\)?"
                .........................^
[00:00.591]  sclang-language.el:115:3: In sclang-beginning-of-defun-regexp: Repetition subsumes preceding repetition (pos 143)
               "\\(?:^\\s *\\(\\<\\(?:Meta_\\)?[A-Z]\\(?:\\sw\\|\\s_\\)*\\)\\(?:\\s *:\\s *\\(\\<\\(?:Meta_\\)?[A-Z]\\(?:\\sw\\|\\s_\\)*\\)\\)?[[:space:]]*{\\)\\|\\(?:^\\((\\)\\s *\\(?:/[/*]?.*\\)?\\)"
                ................................................................................................................................................................................^
[00:00.591]  sclang-language.el:125:3: In sclang-method-definition-spec-regexp: Duplicated ‘\’ inside character alternative (pos 52)
               "\\(\\<\\(?:Meta_\\)?[A-Z]\\(?:\\sw\\|\\s_\\)*\\)-\\(\\(?:[-!%&\\*\\+/<=>\\?@|]+\\)\\|\\(?:[a-zA-Z]\\(?:\\sw\\|\\s_\\)*_?\\)\\)"
                .................................................................^
[00:00.591]  sclang-language.el:125:3: In sclang-method-definition-spec-regexp: Duplicated ‘\’ inside character alternative (pos 58)
               "\\(\\<\\(?:Meta_\\)?[A-Z]\\(?:\\sw\\|\\s_\\)*\\)-\\(\\(?:[-!%&\\*\\+/<=>\\?@|]+\\)\\|\\(?:[a-zA-Z]\\(?:\\sw\\|\\s_\\)*_?\\)\\)"
                ........................................................................^
[00:00.591]  sclang-language.el:653:39: In call to re-search-backward: Duplicated ‘\’ inside character alternative (pos 65)
               "\\<\\(?:Meta_\\)?[A-Z]\\(?:\\sw\\|\\s_\\)*[ \t\n]*\\(?:\\.[ \t\n]*\\(\\(?:[-!%&\\*\\+/<=>\\?@|]+\\)\\|\\(?:[a-zA-Z]\\(?:\\sw\\|\\s_\\)*_?\\)\\)\\)?[ \t\n]*("
                ..................................................................................^
[00:00.591]  sclang-language.el:653:39: In call to re-search-backward: Duplicated ‘\’ inside character alternative (pos 71)
               "\\<\\(?:Meta_\\)?[A-Z]\\(?:\\sw\\|\\s_\\)*[ \t\n]*\\(?:\\.[ \t\n]*\\(\\(?:[-!%&\\*\\+/<=>\\?@|]+\\)\\|\\(?:[a-zA-Z]\\(?:\\sw\\|\\s_\\)*_?\\)\\)\\)?[ \t\n]*("
                .........................................................................................^
[00:00.592]  Found 16 warnings in file ‘sclang-language.el’
@zzkt
Copy link
Owner Author

zzkt commented Aug 2, 2022

mostly fixed. the regexps might need more attention #2

@zzkt zzkt closed this as completed Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant