Skip to content

Commit 928ca1c

Browse files
cloud-fanyhuai
authored andcommitted
[SPARK-17102][SQL] bypass UserDefinedGenerator for json format check
## What changes were proposed in this pull request? We use reflection to convert `TreeNode` to json string, and currently don't support arbitrary object. `UserDefinedGenerator` takes a function object, so we should skip json format test for it, or the tests can be flacky, e.g. `DataFrameSuite.simple explode`, this test always fail with scala 2.10(branch 1.6 builds with scala 2.10 by default), but pass with scala 2.11(master branch builds with scala 2.11 by default). ## How was this patch tested? N/A Author: Wenchen Fan <[email protected]> Closes apache#14679 from cloud-fan/json.
1 parent 0b0c8b9 commit 928ca1c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,10 @@ abstract class QueryTest extends PlanTest {
249249
}
250250
p
251251
}.transformAllExpressions {
252-
case a: ImperativeAggregate => return
252+
case _: ImperativeAggregate => return
253253
case _: TypedAggregateExpression => return
254254
case Literal(_, _: ObjectType) => return
255+
case _: UserDefinedGenerator => return
255256
}
256257

257258
// bypass hive tests before we fix all corner cases in hive module.

0 commit comments

Comments
 (0)