Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless use of cat #28

Open
krader1961 opened this issue Jun 28, 2022 · 0 comments
Open

Useless use of cat #28

krader1961 opened this issue Jun 28, 2022 · 0 comments

Comments

@krader1961
Copy link
Contributor

FYI, while responding to elves/elvish#1416 I noticed that alias.org has two lines of this form:

var content = (cat $file | slurp)

There isn't any need for cat and a pipeline, just do var content = (slurp < $file). I know your alias module is probably no longer being actively maintained now that Elvish has edit:add-var but you should still probably review all your Elvish code for useless uses of cat. 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant