Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Belt Splitters do not correctly load the Output Link Setting if it links to a Splitter #452

Closed
Sn1p3rr3c0n opened this issue May 20, 2021 · 2 comments · Fixed by #751
Assignees
Labels
bug Something isn't working C#

Comments

@Sn1p3rr3c0n
Copy link
Collaborator

Reported by ChrisF0001 on Steam. Confirmed by me

Describe the bug

If a Splitter Outputs to another Splitter then the Active Setting of the Output gets set to false regardless of the Saved Value.

To Reproduce
Reproducibility: easy
Steps to reproduce the behavior:

  1. Place a Splitter leading into another splitter
  2. Activate the Output of the First Splitter
  3. Save the Game
  4. Load the Game
  5. Observe that the setting is set to False.

Expected behavior
If a Link is Saved as active it should load as active

Actual Behavior
The Saved Value gets Ignored.
This can be verified by checking the Savefile.

Screenshots
Before & after Saving
image
After Loading
image

@Sn1p3rr3c0n Sn1p3rr3c0n added bug Something isn't working C# labels May 20, 2021
@lilwhitemouse
Copy link
Collaborator

I suspect this is a result of the change to allow splitters to input from multiple directions at the same time. I'll take a look.

@lilwhitemouse
Copy link
Collaborator

Okay, I think it's because of the way Splitters Link() when they Spawn() - they explicitly deactivate incoming links, and the logic isn't set up to handle that scenario. I'll figure out how to make it work; it may need nothing more than removing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C#
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants