Unicode: Fix wide runes in various szenarios #3516
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's cool, it fixes the search issue. But it has some edge-case that isn't covered. |
|
Ok, I will have a look into this in the evening.
Looks like the „fix“ is just half of the truth and this Unicode handling needs some rework.
|
JoeKar
changed the title
JoeKar
force-pushed
the
fix/wide-runes
branch
from
e94ebdd
to
e8cb65f
Compare
JoeKar
force-pushed
the
fix/wide-runes
branch
from
e8cb65f
to
536ad0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@replacement char for incomplete wide runes>marker with wide runesFixes #2277
Fixes #3514