actions: Perform CursorDown with selection like GUI editors do
#3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3091 introduced a small regression in case the actual selection included the new line character, which was ignored on
CursorDown.This PR shall fix this by moving the cursor to the start of the line and performing a down move of two instead of one line. This additionally aligns with the behavior of other editors and respects the already highlighted next line.
In case a selection was active while no new line character was included as the last character the cursor will be moved to the right once, to place it behind the last selected character, which mimics the behavior of GUI editors.
Fixes #3476