Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectWordLeft selects characters to the RIGHT of the cursor #3380

Closed
injust opened this issue Jul 11, 2024 · 7 comments
Closed

SelectWordLeft selects characters to the RIGHT of the cursor #3380

injust opened this issue Jul 11, 2024 · 7 comments

Comments

@injust
Copy link
Contributor

injust commented Jul 11, 2024

Description of the problem or steps to reproduce

  1. Type this:
[]
  1. Put the cursor here:
 [ ]
^
  1. Perform the action SelectWordLeft

Expected result: Nothing is selected, as SelectWordLeft should only select characters to the left of the cursor
Actual result: [ is selected

Note: This bug impacts the default "Alt-Backspace": "DeleteWordLeft" keybinding, causing it to delete characters to the right of the cursor.

Specifications

Commit hash: 68d88b57
OS: macOS Sonoma 14.5
Terminal: Ghostty

@niten94
Copy link
Contributor

niten94 commented Jul 12, 2024

This seems to be fixed in the commit I mentioned in this comment: #3381 (comment)

@injust
Copy link
Contributor Author

injust commented Jul 13, 2024

Confirmed fixed on version 2.0.14-dev.227 (commit hash: a10624cc)

@injust injust closed this as completed Jul 13, 2024
@injust
Copy link
Contributor Author

injust commented Jul 13, 2024

@zyedidia Is it possible to cut a release soon with this bug fix? This is a pretty unfortunate bug considering how easy it is to hit.

@niten94
Copy link
Contributor

niten94 commented Jul 13, 2024

There has been a lot more commits added compared to previous releases so I think a new release already has to be made, but I do not know if v2.0.14 has been discussed with @zyedidia. There may still be bugs the other maintainers decided to fix before releasing v2.0.14 but there is a discussion with comments about it: #3254

@zyedidia asked the maintainers to send an email message when making a new release in this comment: #2956 (comment)

I do not think you are trying to rush them, but I think the maintainers (and others) helped a lot so I will just say that I do not want them to rush.

@dmaluka
Copy link
Collaborator

dmaluka commented Jul 14, 2024

I think @JoeKar and I already have permissions to make releases. But I don't think we should make a new release right now. At the very least, there is a long due pending PR #3127 which fixes a lot of major syntax highlighting bugs, and I think we should at least merge this PR before the next release (but I'm constantly struggling to carve out some free time to properly review it).

And besides that, since we know there is still a number of major bugs, shouldn't we first at least try to fix as many of them as possible, instead of just releasing something that we know still sucks in so many ways?

@Andriamanitra
Copy link
Contributor

Andriamanitra commented Jul 14, 2024

And besides that, since we know there is still a number of major bugs, shouldn't we first at least try to fix as many of them as possible, instead of just releasing something that we know still sucks in so many ways?

I think looking at issues closed since last release is a better metric to look at than open issues. There have already been several issues opened for bugs that are already fixed in master which is a pretty good indicator that users would get value from a new release. The open issues can always be fixed in the next one.

Delaying the release further to sneak in some major fixes that are close to completion is fine but IMO the release should have already happened.

@JoeKar
Copy link
Collaborator

JoeKar commented Jul 15, 2024

I can understand all of your positions, but please let us leave this issue closed unless something really related comes up.
Let us all continue in #3254. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants