Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globally refocus after search #1049

Open
Rohitth007 opened this issue Jun 7, 2021 · 1 comment
Open

Globally refocus after search #1049

Rohitth007 opened this issue Jun 7, 2021 · 1 comment
Labels
area: UI General user interface update enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org help wanted This issue should be clear enough to work on

Comments

@Rohitth007
Copy link
Collaborator

We currently can locally refocus back to the index before panel search in the left and right column.
A more useful feature would be to focus back to where it was before search if it was not in the stream/topic/user list.
Eg: If we are in the message view and press q, escaping should bring us back to that message.

@Rohitth007 Rohitth007 added enhancement New feature or request area: UI General user interface update labels Jun 7, 2021
@neiljp
Copy link
Collaborator

neiljp commented Apr 22, 2024

Rereading, the concept appears to be that

  • currently going in/out of search in the side panels saves the previous position, eg. see view: Fix focus index before and after Panel Search. #978
  • (this was also updated for topic position per stream subsequently)
  • upon noticing a search keypress we could also save the previous state, such as if in the central message list (or elsewhere)
  • backing out of a search (typically esc) would then restore that state

If we went with this, this could interact with displaying what Esc does, via eg. #1060 (comment)

Discussion was at: https://chat.zulip.org/#narrow/stream/206-zulip-terminal/topic/Globally.20refocus.20after.20search.20.23T1049

To explore the issue, please read that and continue discussion there.

@neiljp neiljp added help wanted This issue should be clear enough to work on further discussion required Discuss this on #zulip-terminal on chat.zulip.org labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI General user interface update enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org help wanted This issue should be clear enough to work on
Projects
None yet
Development

No branches or pull requests

2 participants