Skip to content

api: Don't allow connecting to servers <7.0; show nag banner on <8.0 #5922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

api: Don't allow connecting to servers <7.0; show nag banner on <8.0 #5922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/apiErrors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export const interpretApiResponse = (httpStatus: number, data: mixed): mixed =>
*/
// This should lag a bit behind the threshold version for ServerCompatBanner
// (kMinSupportedVersion), to give users time to see and act on the banner.
export const kMinAllowedServerVersion: ZulipVersion = new ZulipVersion('5.0');
export const kMinAllowedServerVersion: ZulipVersion = new ZulipVersion('7.0');

/**
* An error we throw in API bindings on finding a server is too old.
Expand Down
4 changes: 2 additions & 2 deletions src/common/ServerCompatBanner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ export const kServerSupportDocUrl: URL = new URL(
* See also kMinAllowedServerVersion in apiErrors.js, for the version below
* which we just refuse to connect.
*/
export const kMinSupportedVersion: ZulipVersion = new ZulipVersion('7.0');
export const kMinSupportedVersion: ZulipVersion = new ZulipVersion('8.0');

/**
* The next value we'll give to kMinSupportedVersion in the future.
*
* This should be the next major Zulip Server version after kMinSupportedVersion.
*/
export const kNextMinSupportedVersion: ZulipVersion = new ZulipVersion('8.0');
export const kNextMinSupportedVersion: ZulipVersion = new ZulipVersion('9.0');

type Props = $ReadOnly<{||}>;

Expand Down