From 9e542fba1c7fd65dfc694b5279dea9db2d204eb7 Mon Sep 17 00:00:00 2001
From: Greg Price <greg@zulip.com>
Date: Tue, 12 Apr 2022 18:00:30 -0700
Subject: [PATCH] compat: Show "unsupported" banner for 2.1.x, too

Zulip Server 3.0 is now about 21 months old, well over the 18 months
we say we support.  So it's time we start nagging people to upgrade.
---
 src/common/ServerCompatBanner.js | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/src/common/ServerCompatBanner.js b/src/common/ServerCompatBanner.js
index 2162d98f1a3..8031f780dd8 100644
--- a/src/common/ServerCompatBanner.js
+++ b/src/common/ServerCompatBanner.js
@@ -11,9 +11,25 @@ import { dismissCompatNotice } from '../session/sessionActions';
 import { openLinkWithUserPreference } from '../utils/openLink';
 import { ZulipVersion } from '../utils/zulipVersion';
 
-// The oldest version we currently support. Should match what we say at
-//   https://zulip.readthedocs.io/en/stable/overview/release-lifecycle.html#compatibility-and-upgrading.
-export const kMinSupportedVersion: ZulipVersion = new ZulipVersion('2.1.0');
+/**
+ * The oldest version we currently support.
+ *
+ * Should match what we say at:
+ *   https://zulip.readthedocs.io/en/stable/overview/release-lifecycle.html#compatibility-and-upgrading
+ */
+// "2.2.0" is a funny way of saying "3.0", differing in that it accepts
+// versions like 2.2-dev-1234-g08192a3b4c.  Some servers running versions
+// from Git describe their versions that way: specifically those installed
+// from commits in the range 2.2-dev..3.0-dev (2019-12 to 2020-06), before
+// we decided to rename the then-upcoming release from 2.2 to 3.0; and
+// potentially upgraded since then, but not past the upgrader bugfix commit
+// 5.0~960 (2022-01).
+//
+// By the time we want to desupport 3.x circa 2022-11, it should make sense
+// to simply say 4.0 here.  By that point the affected versions from Git
+// will be nearly a year old, and it's pretty OK to just say those servers
+// should upgrade too.
+export const kMinSupportedVersion: ZulipVersion = new ZulipVersion('2.2.0');
 // Notes on known breakage at older versions:
 //  * Before 1.8, the server doesn't send found_newest / found_oldest on
 //    fetching messages, and so `state.caughtUp` will never have truthy
@@ -25,7 +41,7 @@ export const kMinSupportedVersion: ZulipVersion = new ZulipVersion('2.1.0');
  *
  * This should be the next major Zulip Server version after kMinSupportedVersion.
  */
-export const kNextMinSupportedVersion: ZulipVersion = new ZulipVersion('3.0');
+export const kNextMinSupportedVersion: ZulipVersion = new ZulipVersion('4.0');
 
 type Props = $ReadOnly<{||}>;