emoji: Rename type RealmEmojiType to ImageEmojiType.

Zulip also supports "Zulip extra emoji".  These are very similar to
realm emoji, and we'll group them together under the name of "image
emoji".  Thus this renaming will help us in managing Zulip extra
emojis in the similar way we handle realm emoji.

Mark `author` as optional.  We aren't using it anywhere.  This marking
it as optional will include Zulip extra emoji also in this category.

Author: jainkuniya

src/api/modelTypes.js

@@ -12,8 +12,8 @@
 //
 //
 
-export type RealmEmojiType = $ReadOnly<{|
-  author: $ReadOnly<{|
+export type ImageEmojiType = $ReadOnly<{|
+  author?: $ReadOnly<{|
     email: string,
     full_name: string,
     id: number,
@@ -28,7 +28,7 @@ export type RealmEmojiType = $ReadOnly<{|
 |}>;
 
 export type RealmEmojiById = $ReadOnly<{
-  [id: string]: RealmEmojiType,
+  [id: string]: ImageEmojiType,
 }>;
 
 export type RealmFilter = [string, string, number];

src/emoji/EmojiRow.js

@@ -3,7 +3,7 @@ import React, { PureComponent } from 'react';
 import { connect } from 'react-redux';
 import { StyleSheet, View } from 'react-native';
 
-import type { GlobalState, RealmEmojiType } from '../types';
+import type { GlobalState, ImageEmojiType } from '../types';
 import { RawLabel, Touchable } from '../common';
 import Emoji from './Emoji';
 import RealmEmoji from './RealmEmoji';
@@ -22,7 +22,7 @@ const styles = StyleSheet.create({
 
 type Props = {|
   name: string,
-  realmEmoji: RealmEmojiType | void,
+  realmEmoji: ImageEmojiType | void,
   onPress: (name: string) => void,
 |};
 

src/emoji/RealmEmoji.js

@@ -3,7 +3,7 @@
 import React, { PureComponent } from 'react';
 import { StyleSheet, Image } from 'react-native';
 
-import type { RealmEmojiType } from '../types';
+import type { ImageEmojiType } from '../types';
 
 const styles = StyleSheet.create({
   image: {
@@ -13,7 +13,7 @@ const styles = StyleSheet.create({
 });
 
 type Props = {|
-  emoji: RealmEmojiType,
+  emoji: ImageEmojiType,
 |};
 
 export default class RealmEmoji extends PureComponent<Props> {

src/emoji/data.js

@@ -1,7 +1,7 @@
 /* @flow strict-local */
 import 'string.fromcodepoint'; // eslint-disable-line spellcheck/spell-checker
 
-import type { RealmEmojiType } from '../types';
+import type { ImageEmojiType } from '../types';
 import { unicodeCodeByName, override } from './codePointMap';
 
 const unicodeEmojiNames = Object.keys(unicodeCodeByName);
@@ -26,7 +26,7 @@ export const codeToEmojiMap = unicodeEmojiNames.reduce((obj, name) => {
 
 export const getFilteredEmojiNames = (
   query: string,
-  activeRealmEmojiByName: $ReadOnly<{ [string]: RealmEmojiType }>,
+  activeRealmEmojiByName: $ReadOnly<{ [string]: ImageEmojiType }>,
 ): string[] => {
   const names = [...unicodeEmojiNames, ...Object.keys(activeRealmEmojiByName)];
   return Array.from(new Set([...names.filter(x => x.indexOf(query) === 0).sort()]));

src/emoji/emojiSelectors.js

@@ -1,6 +1,6 @@
 /* @flow strict-local */
 import { createSelector } from 'reselect';
-import type { Selector, RealmEmojiById, RealmEmojiType } from '../types';
+import type { Selector, RealmEmojiById, ImageEmojiType } from '../types';
 import { getRawRealmEmoji } from '../directSelectors';
 import { getIdentity } from '../account/accountsSelectors';
 import { getFullUrl } from '../utils/url';
@@ -26,7 +26,7 @@ export const getActiveRealmEmojiById: Selector<RealmEmojiById> = createSelector(
       }, {}),
 );
 
-export const getAllRealmEmojiByName: Selector<{ [string]: RealmEmojiType }> = createSelector(
+export const getAllRealmEmojiByName: Selector<{ [string]: ImageEmojiType }> = createSelector(
   getAllRealmEmojiById,
   emojis =>
     Object.keys(emojis).reduce((result, id) => {
@@ -35,7 +35,7 @@ export const getAllRealmEmojiByName: Selector<{ [string]: RealmEmojiType }> = cr
     }, {}),
 );
 
-export const getActiveRealmEmojiByName: Selector<{ [string]: RealmEmojiType }> = createSelector(
+export const getActiveRealmEmojiByName: Selector<{ [string]: ImageEmojiType }> = createSelector(
   getActiveRealmEmojiById,
   emojis =>
     Object.keys(emojis).reduce((result, id) => {

src/webview/MessageList.js

@@ -18,7 +18,7 @@ import type {
   Message,
   MuteState,
   Narrow,
-  RealmEmojiType,
+  ImageEmojiType,
   RenderedSectionDescriptor,
   Subscription,
   ThemeName,
@@ -68,7 +68,7 @@ export type BackgroundData = $ReadOnly<{
   flags: FlagsState,
   mute: MuteState,
   ownEmail: string,
-  allRealmEmojiById: $ReadOnly<{ [id: string]: RealmEmojiType }>,
+  allRealmEmojiById: $ReadOnly<{ [id: string]: ImageEmojiType }>,
   twentyFourHourTime: boolean,
   subscriptions: Subscription[],
 }>;

src/webview/html/messageAsHtml.js

@@ -7,7 +7,7 @@ import type {
   Message,
   Outbox,
   Reaction,
-  RealmEmojiType,
+  ImageEmojiType,
 } from '../../types';
 import type { BackgroundData } from '../MessageList';
 import { getAvatarFromMessage } from '../../utils/avatar';
@@ -30,7 +30,7 @@ const messageTagsAsHtml = (isStarred: boolean, timeEdited: number | void): strin
 
 const messageReactionAsHtml = (
   reaction: AggregatedReaction,
-  allRealmEmojiById: $ReadOnly<{ [id: string]: RealmEmojiType }>,
+  allRealmEmojiById: $ReadOnly<{ [id: string]: ImageEmojiType }>,
 ): string =>
   template`<span onClick="" class="reaction${reaction.selfReacted ? ' self-voted' : ''}"
         data-name="${reaction.name}"
@@ -44,7 +44,7 @@ const messageReactionAsHtml = (
 const messageReactionListAsHtml = (
   reactions: $ReadOnlyArray<Reaction>,
   ownEmail: string,
-  allRealmEmojiById: $ReadOnly<{ [id: string]: RealmEmojiType }>,
+  allRealmEmojiById: $ReadOnly<{ [id: string]: ImageEmojiType }>,
 ): string => {
   if (reactions.length === 0) {
     return '';