Skip to content

Commit db64354

Browse files
chrisbobbegnprice
chrisbobbe
authored and
gnprice
committed
page: Split empty-page placeholder messages into header and message
Following a new Figma frame that specifies larger text for the first part: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=11194-18392&m=dev
1 parent 8942c91 commit db64354

27 files changed

+389
-260
lines changed

‎assets/l10n/app_en.arb‎

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@
8080
"@allChannelsPageTitle": {
8181
"description": "Title for the 'All channels' page."
8282
},
83-
"allChannelsEmptyPlaceholder": "There are no channels you can view in this organization.",
84-
"@allChannelsEmptyPlaceholder": {
83+
"allChannelsEmptyPlaceholderHeader": "There are no channels you can view in this organization.",
84+
"@allChannelsEmptyPlaceholderHeader": {
8585
"description": "Centered text on the 'All channels' page saying that there is no content to show."
8686
},
8787
"profileButtonSendDirectMessage": "Send direct message",
@@ -1090,10 +1090,14 @@
10901090
"@inboxPageTitle": {
10911091
"description": "Title for the page with unreads."
10921092
},
1093-
"inboxEmptyPlaceholder": "There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.",
1094-
"@inboxEmptyPlaceholder": {
1093+
"inboxEmptyPlaceholderHeader": "There are no unread messages in your inbox.",
1094+
"@inboxEmptyPlaceholderHeader": {
10951095
"description": "Centered text on the 'Inbox' page saying that there is no content to show."
10961096
},
1097+
"inboxEmptyPlaceholderMessage": "Use the buttons below to view the combined feed or list of channels.",
1098+
"@inboxEmptyPlaceholderMessage": {
1099+
"description": "Additional centered text on the 'Inbox' page saying that there is no content to show."
1100+
},
10971101
"recentDmConversationsPageTitle": "Direct messages",
10981102
"@recentDmConversationsPageTitle": {
10991103
"description": "Title for the page with a list of DM conversations."
@@ -1102,10 +1106,14 @@
11021106
"@recentDmConversationsSectionHeader": {
11031107
"description": "Heading for direct messages section on the 'Inbox' message view."
11041108
},
1105-
"recentDmConversationsEmptyPlaceholder": "You have no direct messages yet! Why not start the conversation?",
1106-
"@recentDmConversationsEmptyPlaceholder": {
1109+
"recentDmConversationsEmptyPlaceholderHeader": "You have no direct messages yet!",
1110+
"@recentDmConversationsEmptyPlaceholderHeader": {
11071111
"description": "Centered text on the 'Direct messages' page saying that there is no content to show."
11081112
},
1113+
"recentDmConversationsEmptyPlaceholderMessage": "Why not start a conversation?",
1114+
"@recentDmConversationsEmptyPlaceholderMessage": {
1115+
"description": "Additional centered text on the 'Direct messages' page saying that there is no content to show."
1116+
},
11091117
"combinedFeedPageTitle": "Combined feed",
11101118
"@combinedFeedPageTitle": {
11111119
"description": "Page title for the 'Combined feed' message view."
@@ -1122,12 +1130,12 @@
11221130
"@channelsPageTitle": {
11231131
"description": "Title for the page with a list of subscribed channels."
11241132
},
1125-
"channelsEmptyPlaceholder": "You’re not subscribed to any channels yet.",
1126-
"@channelsEmptyPlaceholder": {
1133+
"channelsEmptyPlaceholderHeader": "You’re not subscribed to any channels yet.",
1134+
"@channelsEmptyPlaceholderHeader": {
11271135
"description": "Centered text on the 'Channels' page saying that there is no content to show."
11281136
},
1129-
"channelsEmptyPlaceholderWithAllChannelsLink": "You’re not subscribed to any channels yet. Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.",
1130-
"@channelsEmptyPlaceholderWithAllChannelsLink": {
1137+
"channelsEmptyPlaceholderMessage": "Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.",
1138+
"@channelsEmptyPlaceholderMessage": {
11311139
"description": "Centered text on the 'Channels' page saying that there is no content to show, with a link to 'All channels'.",
11321140
"placeholders": {
11331141
"allChannelsPageTitle": {"type": "String", "example": "All channels"}

‎lib/generated/l10n/zulip_localizations.dart‎

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ abstract class ZulipLocalizations {
263263
///
264264
/// In en, this message translates to:
265265
/// **'There are no channels you can view in this organization.'**
266-
String get allChannelsEmptyPlaceholder;
266+
String get allChannelsEmptyPlaceholderHeader;
267267

268268
/// Label for button in profile screen to navigate to DMs with the shown user.
269269
///
@@ -1620,8 +1620,14 @@ abstract class ZulipLocalizations {
16201620
/// Centered text on the 'Inbox' page saying that there is no content to show.
16211621
///
16221622
/// In en, this message translates to:
1623-
/// **'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.'**
1624-
String get inboxEmptyPlaceholder;
1623+
/// **'There are no unread messages in your inbox.'**
1624+
String get inboxEmptyPlaceholderHeader;
1625+
1626+
/// Additional centered text on the 'Inbox' page saying that there is no content to show.
1627+
///
1628+
/// In en, this message translates to:
1629+
/// **'Use the buttons below to view the combined feed or list of channels.'**
1630+
String get inboxEmptyPlaceholderMessage;
16251631

16261632
/// Title for the page with a list of DM conversations.
16271633
///
@@ -1638,8 +1644,14 @@ abstract class ZulipLocalizations {
16381644
/// Centered text on the 'Direct messages' page saying that there is no content to show.
16391645
///
16401646
/// In en, this message translates to:
1641-
/// **'You have no direct messages yet! Why not start the conversation?'**
1642-
String get recentDmConversationsEmptyPlaceholder;
1647+
/// **'You have no direct messages yet!'**
1648+
String get recentDmConversationsEmptyPlaceholderHeader;
1649+
1650+
/// Additional centered text on the 'Direct messages' page saying that there is no content to show.
1651+
///
1652+
/// In en, this message translates to:
1653+
/// **'Why not start a conversation?'**
1654+
String get recentDmConversationsEmptyPlaceholderMessage;
16431655

16441656
/// Page title for the 'Combined feed' message view.
16451657
///
@@ -1669,15 +1681,13 @@ abstract class ZulipLocalizations {
16691681
///
16701682
/// In en, this message translates to:
16711683
/// **'You’re not subscribed to any channels yet.'**
1672-
String get channelsEmptyPlaceholder;
1684+
String get channelsEmptyPlaceholderHeader;
16731685

16741686
/// Centered text on the 'Channels' page saying that there is no content to show, with a link to 'All channels'.
16751687
///
16761688
/// In en, this message translates to:
1677-
/// **'You’re not subscribed to any channels yet. Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.'**
1678-
String channelsEmptyPlaceholderWithAllChannelsLink(
1679-
String allChannelsPageTitle,
1680-
);
1689+
/// **'Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.'**
1690+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle);
16811691

16821692
/// Title for the page about sharing content received from other apps.
16831693
///

‎lib/generated/l10n/zulip_localizations_ar.dart‎

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
7474
String get allChannelsPageTitle => 'All channels';
7575

7676
@override
77-
String get allChannelsEmptyPlaceholder =>
77+
String get allChannelsEmptyPlaceholderHeader =>
7878
'There are no channels you can view in this organization.';
7979

8080
@override
@@ -911,8 +911,12 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
911911
String get inboxPageTitle => 'Inbox';
912912

913913
@override
914-
String get inboxEmptyPlaceholder =>
915-
'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.';
914+
String get inboxEmptyPlaceholderHeader =>
915+
'There are no unread messages in your inbox.';
916+
917+
@override
918+
String get inboxEmptyPlaceholderMessage =>
919+
'Use the buttons below to view the combined feed or list of channels.';
916920

917921
@override
918922
String get recentDmConversationsPageTitle => 'Direct messages';
@@ -921,8 +925,12 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
921925
String get recentDmConversationsSectionHeader => 'Direct messages';
922926

923927
@override
924-
String get recentDmConversationsEmptyPlaceholder =>
925-
'You have no direct messages yet! Why not start the conversation?';
928+
String get recentDmConversationsEmptyPlaceholderHeader =>
929+
'You have no direct messages yet!';
930+
931+
@override
932+
String get recentDmConversationsEmptyPlaceholderMessage =>
933+
'Why not start a conversation?';
926934

927935
@override
928936
String get combinedFeedPageTitle => 'Combined feed';
@@ -937,14 +945,12 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
937945
String get channelsPageTitle => 'Channels';
938946

939947
@override
940-
String get channelsEmptyPlaceholder =>
948+
String get channelsEmptyPlaceholderHeader =>
941949
'You’re not subscribed to any channels yet.';
942950

943951
@override
944-
String channelsEmptyPlaceholderWithAllChannelsLink(
945-
String allChannelsPageTitle,
946-
) {
947-
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
952+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
953+
return 'Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
948954
}
949955

950956
@override

‎lib/generated/l10n/zulip_localizations_de.dart‎

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
7474
String get allChannelsPageTitle => 'Alle Kanäle';
7575

7676
@override
77-
String get allChannelsEmptyPlaceholder =>
78-
'Es gibt in dieser Organisation keine Kanäle die du ansehen kannst.';
77+
String get allChannelsEmptyPlaceholderHeader =>
78+
'There are no channels you can view in this organization.';
7979

8080
@override
8181
String get profileButtonSendDirectMessage => 'Direktnachricht senden';
@@ -936,8 +936,12 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
936936
String get inboxPageTitle => 'Eingang';
937937

938938
@override
939-
String get inboxEmptyPlaceholder =>
940-
'Es sind keine ungelesenen Nachrichten in deinem Eingang. Verwende die Buttons unten, um den kombinierten Feed oder die Kanalliste anzusehen.';
939+
String get inboxEmptyPlaceholderHeader =>
940+
'There are no unread messages in your inbox.';
941+
942+
@override
943+
String get inboxEmptyPlaceholderMessage =>
944+
'Use the buttons below to view the combined feed or list of channels.';
941945

942946
@override
943947
String get recentDmConversationsPageTitle => 'Direktnachrichten';
@@ -946,8 +950,12 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
946950
String get recentDmConversationsSectionHeader => 'Direktnachrichten';
947951

948952
@override
949-
String get recentDmConversationsEmptyPlaceholder =>
950-
'Du hast noch keine Direktnachrichten! Warum nicht die Unterhaltung beginnen?';
953+
String get recentDmConversationsEmptyPlaceholderHeader =>
954+
'You have no direct messages yet!';
955+
956+
@override
957+
String get recentDmConversationsEmptyPlaceholderMessage =>
958+
'Why not start a conversation?';
951959

952960
@override
953961
String get combinedFeedPageTitle => 'Kombinierter Feed';
@@ -962,13 +970,12 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
962970
String get channelsPageTitle => 'Kanäle';
963971

964972
@override
965-
String get channelsEmptyPlaceholder => 'Du hast noch keine Kanäle abonniert.';
973+
String get channelsEmptyPlaceholderHeader =>
974+
'You’re not subscribed to any channels yet.';
966975

967976
@override
968-
String channelsEmptyPlaceholderWithAllChannelsLink(
969-
String allChannelsPageTitle,
970-
) {
971-
return 'Du hast noch keine Kanäle abonniert. Probiere zu <z-link>$allChannelsPageTitle</z-link> zu gehen und ein paar von ihnen beizutreten.';
977+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
978+
return 'Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
972979
}
973980

974981
@override

‎lib/generated/l10n/zulip_localizations_el.dart‎

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
7474
String get allChannelsPageTitle => 'All channels';
7575

7676
@override
77-
String get allChannelsEmptyPlaceholder =>
77+
String get allChannelsEmptyPlaceholderHeader =>
7878
'There are no channels you can view in this organization.';
7979

8080
@override
@@ -911,8 +911,12 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
911911
String get inboxPageTitle => 'Inbox';
912912

913913
@override
914-
String get inboxEmptyPlaceholder =>
915-
'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.';
914+
String get inboxEmptyPlaceholderHeader =>
915+
'There are no unread messages in your inbox.';
916+
917+
@override
918+
String get inboxEmptyPlaceholderMessage =>
919+
'Use the buttons below to view the combined feed or list of channels.';
916920

917921
@override
918922
String get recentDmConversationsPageTitle => 'Direct messages';
@@ -921,8 +925,12 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
921925
String get recentDmConversationsSectionHeader => 'Direct messages';
922926

923927
@override
924-
String get recentDmConversationsEmptyPlaceholder =>
925-
'You have no direct messages yet! Why not start the conversation?';
928+
String get recentDmConversationsEmptyPlaceholderHeader =>
929+
'You have no direct messages yet!';
930+
931+
@override
932+
String get recentDmConversationsEmptyPlaceholderMessage =>
933+
'Why not start a conversation?';
926934

927935
@override
928936
String get combinedFeedPageTitle => 'Combined feed';
@@ -937,14 +945,12 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
937945
String get channelsPageTitle => 'Channels';
938946

939947
@override
940-
String get channelsEmptyPlaceholder =>
948+
String get channelsEmptyPlaceholderHeader =>
941949
'You’re not subscribed to any channels yet.';
942950

943951
@override
944-
String channelsEmptyPlaceholderWithAllChannelsLink(
945-
String allChannelsPageTitle,
946-
) {
947-
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
952+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
953+
return 'Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
948954
}
949955

950956
@override

‎lib/generated/l10n/zulip_localizations_en.dart‎

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
7474
String get allChannelsPageTitle => 'All channels';
7575

7676
@override
77-
String get allChannelsEmptyPlaceholder =>
77+
String get allChannelsEmptyPlaceholderHeader =>
7878
'There are no channels you can view in this organization.';
7979

8080
@override
@@ -911,8 +911,12 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
911911
String get inboxPageTitle => 'Inbox';
912912

913913
@override
914-
String get inboxEmptyPlaceholder =>
915-
'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.';
914+
String get inboxEmptyPlaceholderHeader =>
915+
'There are no unread messages in your inbox.';
916+
917+
@override
918+
String get inboxEmptyPlaceholderMessage =>
919+
'Use the buttons below to view the combined feed or list of channels.';
916920

917921
@override
918922
String get recentDmConversationsPageTitle => 'Direct messages';
@@ -921,8 +925,12 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
921925
String get recentDmConversationsSectionHeader => 'Direct messages';
922926

923927
@override
924-
String get recentDmConversationsEmptyPlaceholder =>
925-
'You have no direct messages yet! Why not start the conversation?';
928+
String get recentDmConversationsEmptyPlaceholderHeader =>
929+
'You have no direct messages yet!';
930+
931+
@override
932+
String get recentDmConversationsEmptyPlaceholderMessage =>
933+
'Why not start a conversation?';
926934

927935
@override
928936
String get combinedFeedPageTitle => 'Combined feed';
@@ -937,14 +945,12 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
937945
String get channelsPageTitle => 'Channels';
938946

939947
@override
940-
String get channelsEmptyPlaceholder =>
948+
String get channelsEmptyPlaceholderHeader =>
941949
'You’re not subscribed to any channels yet.';
942950

943951
@override
944-
String channelsEmptyPlaceholderWithAllChannelsLink(
945-
String allChannelsPageTitle,
946-
) {
947-
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
952+
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
953+
return 'Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
948954
}
949955

950956
@override

0 commit comments

Comments
 (0)