compose: Show maxTopicLength in the error message

Author: AhmedTareek

assets/l10n/app_en.arb

@@ -526,9 +526,12 @@
   "@loginErrorMissingUsername": {
     "description": "Error message when an empty username was provided."
   },
-  "topicValidationErrorTooLong": "Topic length shouldn't be greater than 60 characters.",
+  "topicValidationErrorTooLong": "Topic length shouldn't be greater than {num, plural, =1{1 character} other{{num} characters}}.",
   "@topicValidationErrorTooLong": {
-    "description": "Topic validation error when topic is too long."
+    "description": "Topic validation error when topic is too long.",
+    "placeholders": {
+      "num": {"type": "int", "example": "60"}
+    }
   },
   "topicValidationErrorMandatoryButEmpty": "Topics are required in this organization.",
   "@topicValidationErrorMandatoryButEmpty": {

lib/generated/l10n/zulip_localizations.dart

@@ -810,8 +810,8 @@ abstract class ZulipLocalizations {
   /// Topic validation error when topic is too long.
   ///
   /// In en, this message translates to:
-  /// **'Topic length shouldn\'t be greater than 60 characters.'**
-  String get topicValidationErrorTooLong;
+  /// **'Topic length shouldn\'t be greater than {num, plural, =1{1 character} other{{num} characters}}.'**
+  String topicValidationErrorTooLong(int num);
 
   /// Topic validation error when topic is required but was empty.
   ///

lib/generated/l10n/zulip_localizations_ar.dart

@@ -408,7 +408,15 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
   String get loginErrorMissingUsername => 'Please enter your username.';
 
   @override
-  String get topicValidationErrorTooLong => 'Topic length shouldn\'t be greater than 60 characters.';
+  String topicValidationErrorTooLong(int num) {
+    String _temp0 = intl.Intl.pluralLogic(
+      num,
+      locale: localeName,
+      other: '$num characters',
+      one: '1 character',
+    );
+    return 'Topic length shouldn\'t be greater than $_temp0.';
+  }
 
   @override
   String get topicValidationErrorMandatoryButEmpty => 'Topics are required in this organization.';

lib/generated/l10n/zulip_localizations_en.dart

@@ -408,7 +408,15 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
   String get loginErrorMissingUsername => 'Please enter your username.';
 
   @override
-  String get topicValidationErrorTooLong => 'Topic length shouldn\'t be greater than 60 characters.';
+  String topicValidationErrorTooLong(int num) {
+    String _temp0 = intl.Intl.pluralLogic(
+      num,
+      locale: localeName,
+      other: '$num characters',
+      one: '1 character',
+    );
+    return 'Topic length shouldn\'t be greater than $_temp0.';
+  }
 
   @override
   String get topicValidationErrorMandatoryButEmpty => 'Topics are required in this organization.';

lib/generated/l10n/zulip_localizations_ja.dart

@@ -408,7 +408,15 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
   String get loginErrorMissingUsername => 'Please enter your username.';
 
   @override
-  String get topicValidationErrorTooLong => 'Topic length shouldn\'t be greater than 60 characters.';
+  String topicValidationErrorTooLong(int num) {
+    String _temp0 = intl.Intl.pluralLogic(
+      num,
+      locale: localeName,
+      other: '$num characters',
+      one: '1 character',
+    );
+    return 'Topic length shouldn\'t be greater than $_temp0.';
+  }
 
   @override
   String get topicValidationErrorMandatoryButEmpty => 'Topics are required in this organization.';

lib/generated/l10n/zulip_localizations_nb.dart

@@ -408,7 +408,15 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
   String get loginErrorMissingUsername => 'Please enter your username.';
 
   @override
-  String get topicValidationErrorTooLong => 'Topic length shouldn\'t be greater than 60 characters.';
+  String topicValidationErrorTooLong(int num) {
+    String _temp0 = intl.Intl.pluralLogic(
+      num,
+      locale: localeName,
+      other: '$num characters',
+      one: '1 character',
+    );
+    return 'Topic length shouldn\'t be greater than $_temp0.';
+  }
 
   @override
   String get topicValidationErrorMandatoryButEmpty => 'Topics are required in this organization.';

lib/generated/l10n/zulip_localizations_pl.dart

@@ -408,7 +408,9 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
   String get loginErrorMissingUsername => 'Proszę podaj nazwę użytkownika.';
 
   @override
-  String get topicValidationErrorTooLong => 'Tytuł nie może być dłuższy niż 60 znaków.';
+  String topicValidationErrorTooLong(int num) {
+    return 'Tytuł nie może być dłuższy niż 60 znaków.';
+  }
 
   @override
   String get topicValidationErrorMandatoryButEmpty => 'Wątki są wymagane przez tę organizację.';

lib/generated/l10n/zulip_localizations_ru.dart

@@ -408,7 +408,9 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
   String get loginErrorMissingUsername => 'Пожалуйста, введите ваше имя пользователя.';
 
   @override
-  String get topicValidationErrorTooLong => 'Длина темы не должна превышать 60 символов.';
+  String topicValidationErrorTooLong(int num) {
+    return 'Длина темы не должна превышать 60 символов.';
+  }
 
   @override
   String get topicValidationErrorMandatoryButEmpty => 'Темы обязательны в этой организации.';

lib/generated/l10n/zulip_localizations_sk.dart

@@ -408,7 +408,15 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
   String get loginErrorMissingUsername => 'Prosím zadajte prihlasovacie meno.';
 
   @override
-  String get topicValidationErrorTooLong => 'Topic length shouldn\'t be greater than 60 characters.';
+  String topicValidationErrorTooLong(int num) {
+    String _temp0 = intl.Intl.pluralLogic(
+      num,
+      locale: localeName,
+      other: '$num characters',
+      one: '1 character',
+    );
+    return 'Topic length shouldn\'t be greater than $_temp0.';
+  }
 
   @override
   String get topicValidationErrorMandatoryButEmpty => 'Topics are required in this organization.';

lib/widgets/compose_box.dart

@@ -131,10 +131,10 @@ enum TopicValidationError {
   mandatoryButEmpty,
   tooLong;
 
-  String message(ZulipLocalizations zulipLocalizations) {
+  String message(ZulipLocalizations zulipLocalizations, {required int maxTopicLength}) {
     switch (this) {
       case tooLong:
-        return zulipLocalizations.topicValidationErrorTooLong;
+        return zulipLocalizations.topicValidationErrorTooLong(maxTopicLength);
       case mandatoryButEmpty:
         return zulipLocalizations.topicValidationErrorMandatoryButEmpty;
     }
@@ -1105,10 +1105,9 @@ class _SendButtonState extends State<_SendButton> {
     if (_hasValidationErrors) {
       final zulipLocalizations = ZulipLocalizations.of(context);
       List<String> validationErrorMessages = [
-        for (final error in (controller is StreamComposeBoxController
-                              ? controller.topic.validationErrors
-                              : const <TopicValidationError>[]))
-          error.message(zulipLocalizations),
+        if (controller is StreamComposeBoxController)
+          for (final error in controller.topic.validationErrors)
+            error.message(zulipLocalizations, maxTopicLength: controller.topic.maxLengthUnicodeCodePoints),
         for (final error in controller.content.validationErrors)
           error.message(zulipLocalizations),
       ];