notif: Use PackageInfo to generate sound resource file URL

Author: rajveermalviya

lib/notifications/display.dart

@@ -62,21 +62,21 @@ class NotificationChannelManager {
   ///   `android.resource://com.zulip.flutter/raw/chime3`
   ///
   /// Based on: https://stackoverflow.com/a/38340580
-  static Uri _resourceUrlFromName({
+  static Future<String> _resourceUrlFromName({
     required String resourceTypeName,
     required String resourceEntryName,
-  }) {
-    const packageName = 'com.zulip.flutter'; // TODO(#407)
+  }) async {
+    final packageInfo = await ZulipBinding.instance.packageInfo;
 
     // URL scheme for Android resource url.
     // See: https://developer.android.com/reference/android/content/ContentResolver#SCHEME_ANDROID_RESOURCE
     const schemeAndroidResource = 'android.resource';
 
     return Uri(
       scheme: schemeAndroidResource,
-      host: packageName,
+      host: packageInfo!.packageName,
       pathSegments: <String>[resourceTypeName, resourceEntryName],
-    );
+    ).toString();
   }
 
   /// Prepare our notification sounds; return a URL for our default sound.
@@ -87,9 +87,9 @@ class NotificationChannelManager {
   /// Returns a URL for our default notification sound: either in shared storage
   /// if we successfully copied it there, or else as our internal resource file.
   static Future<String> _ensureInitNotificationSounds() async {
-    String defaultSoundUrl = _resourceUrlFromName(
+    String defaultSoundUrl = await _resourceUrlFromName(
       resourceTypeName: 'raw',
-      resourceEntryName: kDefaultNotificationSound.resourceName).toString();
+      resourceEntryName: kDefaultNotificationSound.resourceName);
 
     final shouldUseResourceFile = switch (await ZulipBinding.instance.deviceInfo) {
       // Before Android 10 Q, we don't attempt to put the sounds in shared media storage.

test/notifications/display_test.dart

@@ -210,8 +210,8 @@ void main() {
       NotificationChannelManager.kDefaultNotificationSound.resourceName;
     String fakeStoredUrl(String resourceName) =>
       testBinding.androidNotificationHost.fakeStoredNotificationSoundUrl(resourceName);
-    String fakeResourceUrl(String resourceName) =>
-      'android.resource://com.zulip.flutter/raw/$resourceName';
+    String fakeResourceUrl({required String resourceName, String? packageName}) =>
+      'android.resource://${packageName ?? eg.packageInfo().packageName}/raw/$resourceName';
 
     test('on Android 28 (and lower) resource file is used for notification sound', () async {
       addTearDown(testBinding.reset);
@@ -227,7 +227,30 @@ void main() {
         .isEmpty();
       check(androidNotificationHost.takeCreatedChannels())
         .single
-        .soundUrl.equals(fakeResourceUrl(defaultSoundResourceName));
+        .soundUrl.equals(fakeResourceUrl(resourceName: defaultSoundResourceName));
+    });
+
+    test('generates resource file URL from app package name', () async {
+      addTearDown(testBinding.reset);
+      final androidNotificationHost = testBinding.androidNotificationHost;
+
+      testBinding.packageInfoResult = eg.packageInfo(packageName: 'com.example.test');
+
+      // Force the default sound URL to be the resource file URL, by forcing
+      // the Android version to the one where we don't store sounds through the
+      // media store.
+      testBinding.deviceInfoResult =
+        const AndroidDeviceInfo(sdkInt: 28, release: '9');
+
+      await NotificationChannelManager.ensureChannel();
+      check(androidNotificationHost.takeCopySoundResourceToMediaStoreCalls())
+        .isEmpty();
+      check(androidNotificationHost.takeCreatedChannels())
+        .single
+        .soundUrl.equals(fakeResourceUrl(
+          resourceName: defaultSoundResourceName,
+          packageName: 'com.example.test',
+        ));
     });
 
     test('notification sound resource files are being copied to the media store', () async {
@@ -315,7 +338,7 @@ void main() {
         .isEmpty();
       check(androidNotificationHost.takeCreatedChannels())
         .single
-        .soundUrl.equals(fakeResourceUrl(defaultSoundResourceName));
+        .soundUrl.equals(fakeResourceUrl(resourceName: defaultSoundResourceName));
     });
   });