New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common-tags is not tree shakeable by Webpack becasue sideEffects: false is missing in package.json #219

Open

marcopagliarulo opened this issue Apr 17, 2023 · 1 comment

marcopagliarulo commented Apr 17, 2023

Webpack requires a package to declare itself as side effects free in order to tree-shake unused modules.
https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

Common-tags looks actually sideEffect free, but the missing flag prevent a proper tree shake, please add the flag to package.jso

Hexagon commented Jun 17, 2023 •

edited

Loading

This is fixed in the fork proper-tags at https://github.com/hexagon/proper-tags published to npmjs.com/package/proper-tags and deno.land/x/proper_tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment