Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting substitutions - django #61

Open
pniedzwiedzinski opened this issue Feb 19, 2020 · 5 comments
Open

Submitting substitutions - django #61

pniedzwiedzinski opened this issue Feb 19, 2020 · 5 comments
Labels
enhancement New feature or request Epic

Comments

@pniedzwiedzinski
Copy link
Member

So far we are uploading the substitutions by sending the html file via scp to specific localization. But the bottleneck of this solution is that we want to store substitutions for multiple days, which may not be in one file. Also, we want to parse file during the import process, instead of parsing it each time the page refreshes.

I was thinking about creating an endpoint for submitting a new file. This file would be parsed and added to some sort of database.

This would resolve #5 and #54 (since we no longer be handling files)

What do you think about it?

@pniedzwiedzinski pniedzwiedzinski added enhancement New feature or request Epic labels Feb 19, 2020
@AdamSiekierski
Copy link
Member

I think that's a lot better solution - filesystem isn't a good database. We may also add the MongoDB image to our Docker image, so everything could be deployed simultaneously.

@pniedzwiedzinski
Copy link
Member Author

The substitutions have a strict format so I don't think we need to use a NoSQL database for that.

I draft this few requirements for the new system:

  1. As we will be introducing the database we would need some sort of the controller that will take care of the schema migration.
  2. We need to enable updating and deleting the substitutions.

@latachz
Copy link
Member

latachz commented Feb 21, 2020

Maybe we could migrate our backend from Flask to Django. The reason is that in Django we will have an admin panel and easy way to make controllers and migrations.

@pniedzwiedzinski
Copy link
Member Author

And we could use Django admin to update / remove substitutions

@pniedzwiedzinski pniedzwiedzinski changed the title Submitting substitutions Submitting substitutions - django Feb 25, 2020
@pniedzwiedzinski
Copy link
Member Author

I created a new branch for this epic feature - django

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic
Projects
None yet
Development

No branches or pull requests

3 participants