Now greying out the sit param menu item of region is inactive #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EKhan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 93.76% 93.76%
=======================================
Files 75 75
Lines 770 770
Branches 42 42
=======================================
Hits 722 722
Misses 48 48 ☔ View full report in Codecov by Sentry. |
Signed-off-by: EKhan <[email protected]>
Signed-off-by: EKhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Currently the "Show SIT Parameters" menu option can be selected on inactive regions which will cause an error. I've changed this so that this option is greyed out when the region is inactive. I've also added a check in the command so that the error does not surface when executed from the command palette.
How to Test
Connected to a plex with both active and inactive regions and verified that the menu item for 'Show SIT Parameters' is grayed out when the region is inactive. This will also be the case if multi-select is used and includes an inactive region.
Review Checklist
I certify that I have:
Additional Comments
Resolves #167