Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV issues #746

Open
scme0 opened this issue Jan 2, 2025 · 2 comments
Open

TV issues #746

scme0 opened this issue Jan 2, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@scme0
Copy link
Contributor

scme0 commented Jan 2, 2025

Kyoo's version

v4.7.1

What happened?

This is a cumulative list of all the issues I've found so far when running the TV support build: #743

Logging In & signing up

  1. TV Remote navigation doesn't work to the TextInput (It won't move focus to the text input).
  2. Default fields aren't set for server-url, login and register pages (when the pages load, it's nice to have an input selected by default on tv).
  3. When a field is completed, the next field isn't automatically selected.
  4. When the softkeyboard is active, the screen shows white either side of the keyboard on the login and register pages (not on the server url page ?!)
Screenshot 2025-01-02 at 11 28 18
  1. Opinion: It might be worth removing the ability to do a user/pass register on tv? It's pretty annoying to put all the info in manually with a remote anyway. I would say just create the accounts you need on another device (laptop, phone) and then use them to login on the tv.

Actionbar

  1. The Kyoo icon is selectable but it doesn't show focus. We might not need this as a button at all as we have the back button which if clicked a few times should take you to the home page.
  2. The user icon (top right corner) is not selectable in login pages. (If the Kyoo icon is selectable, you can get to the menu, but otherwise you can't.) - moving focus to and from the user icon is a bit annoying - could be easier.
  3. If you do select the user icon and open the user menu:
    a. The menu icon doesn't show it has focus.
    a. The menu shows but you can't click buttons (focus is still on the screen behind).
    c. Clicking the back button goes back to the previous page (or exits the app) instead of closing the menu.
  4. Admin menu and other user options tbd.

Search

  1. TBD - I can access the search page but my Meilisearch pod is not running for some reason so I haven't tested this yet 😅

Browse & Download

  1. Browse and Download at in tabs at the bottom which you can't get to easily with the remote. Recommend having them in the action bar for TV so they are easy to access.
  2. Download is probably not needed for tv
  3. Browse page:
    a. Media Type filter and Name sort menus aren't usable - They also need to show focus correctly

Home

  1. Generally the home page navigates ok with some quirks:
    a. When you're at the first element in a row and you click the left button it goes to the row above - I expect it to do nothing.
    b. When click right continuously eventually it seems to just go to the next row instead of going to the next item in the row.
  2. Recommended row is borked
Screenshot 2025-01-02 at 11 43 48

Video

  1. Videos play but hitting the ok button during playback causes an exception.
Screenshot 2025-01-02 at 11 43 30 2. direction buttons do nothing (back button works) 3. No way to get playback controls to show on screen or to pause playback, subtitles etc.

Performance

  1. I'm not sure if it's just the expo build or if it's the apk as well but performance is pretty bad on my google tv when loading the home page after logging in. I've also had the app crash. It might be better with a normal self-contained release apk though.
@scme0 scme0 added the bug Something isn't working label Jan 2, 2025
@zoriya
Copy link
Owner

zoriya commented Jan 2, 2025

Thank you so much <3

I think logging via code would be cool for TV. I know some apps does it and allows you to simply use your phone and a QR code or a number to instantly login. This is QoL and not a priority, tho.

Bad performance is to be expected ngl, we really need to tackle #268 for this (I plan on migrating to unistyle which should be a gigantic perf boost). This is planned for v4.8.0

@scme0
Copy link
Contributor Author

scme0 commented Jan 2, 2025

Once everything is loaded, navigating around is not too bad - it's really just the initial load. Any perf boost would be good though 👍

I agree a code based login would be great. I think maybe to keep things simple it for now we should remove the register button on TV and only allow users to login. I don't have OIDC configured so I haven't tested that.

I've started fixing the login page issues as I needed to fix them to login to test the rest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants