Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic vote limit adaptation #109

Open
CptPie opened this issue Feb 11, 2021 · 3 comments
Open

Dynamic vote limit adaptation #109

CptPie opened this issue Feb 11, 2021 · 3 comments
Labels
enhancement New feature or request planned Old already planned feature

Comments

@CptPie
Copy link
Collaborator

CptPie commented Feb 11, 2021

As we discussed several times before we considered a dynamic way to allocate (increase) votes depending on the amount of movies added.

A simple formula would be: max(amountMovies/10,voteSetting) i.e. either we have the Votes configured in the server settings or if the calculated value is higher, this calculated vote count is used.

Ofcourse we would need to check edgecases where a user might have negative votes (since the movie count decreased since he spent all votes but got none back) but that shouldnt be too hard.

@CptPie CptPie added enhancement New feature or request planned Old already planned feature labels Feb 11, 2021
@dbaudisch
Copy link

dbaudisch commented Feb 11, 2021

Could the negative edgecase be solved with min(0, abs(max(amount / 10, voteSettings)))?

@CptPie
Copy link
Collaborator Author

CptPie commented Feb 11, 2021

Yeah, something like that could work. Nevertheless i think that negative votes already are cought (i.e. you cant vote if you have <1 votes) but better save then sorry :).

@zorchenhimer
Copy link
Owner

Negative votes are already handled properly. If you have less than zero votes, you need to remove votes from movies until you have a positive number of votes in order to place another vote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned Old already planned feature
Projects
None yet
Development

No branches or pull requests

3 participants