Fcheung proc pidinfo #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with the mach task_info routines is that on modern versions of macos they require the task_for_pid-allow entitlement in order to get the mach_task for another process (because there's all sorts of nefarious things you can do with the mach port) Since macos 10.5 the proc_* family of functions are a better way for getting read-only information about processes.
The api we call to get task info will raise this if you don't have permission (eg trying to get info about another user's processes when not root). By returning nil we'll fall back to the base case of shelling out to `ps` (which doesn't have this issue because `ps` is installed setuid & with the correct entitlements for this)
|
Fix tests for #42 |
schneems
force-pushed
the
fcheung-proc-pidinfo
branch
from
9a50458
to
a60bfd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.