feat: Symlink duplicate npm versions

Author: zodern

Diff for: image/setup/install_node.js

@@ -1,11 +1,10 @@
 var versions = require('./versions.json');
-
 var { spawnSync, execSync } = require('child_process');
+var fs = require('fs');
 
 var nvm = '. "$NVM_DIR/nvm.sh" && nvm';
 
 process.env.PATH += ':/home/app/.nvm';
-
 console.log('\nInstalling node versions');
 
 function log({ output }) {
@@ -23,13 +22,19 @@ for (var i = 0; i < versions.length; i++) {
   });
   log(output);
 
-  var useOutput = spawnSync(nvm, ['use', version.node], {
-    stdio: 'pipe',
-    shell: true
-  });
-  log(useOutput);
-
-  if (version.npm !== 'default') {
+  if (version.npm === (versions[i - 1] ? versions[i - 1].npm : '')) {
+    console.log('symlinking duplicate npm version');
+    const prevVersion = versions[i - 1];
+
+    // This is only correct when the version.node is 0.10.x since nvm stores
+    // newer versions in a different location
+    const targetPath = `/home/app/.nvm/v${version.node}/lib/node_modules/npm`;
+    execSync(`rm -rf ${targetPath}`);
+    fs.symlinkSync(
+      `/home/app/.nvm/versions/node/v${prevVersion.node}/lib/node_modules/npm`,
+      targetPath
+    );
+  } else if (version.npm !== 'default') {
     var npmOutput = execSync(`${nvm} use ${version.node} && npm install --global npm@${version.npm}`, {
       stdio: 'pipe'
     });

Diff for: image/setup/versions.json

@@ -1,14 +1,14 @@
 [
   {
-    "node": "0.10.48",
-    "npm": "3.10.10"
+    "node": "8.8.1",
+    "npm": "default"
   },
   {
     "node": "4.8.4",
     "npm": "3.10.10"
   },
   {
-    "node": "8.11.2",
-    "npm": "default"
+    "node": "0.10.48",
+    "npm": "3.10.10"
   }
-]
+]