Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(studio): Allow adding layers after a layer move #2748

Merged
merged 1 commit into from
Jan 4, 2025
Merged

fix(studio): Allow adding layers after a layer move #2748

merged 1 commit into from
Jan 4, 2025

Conversation

petejohanson
Copy link
Contributor

@petejohanson petejohanson commented Jan 3, 2025 •
edited
Loading

Properly return the available layers in the move layer response.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@petejohanson
fix(studio): Allow adding layers after a layer move
7e2ce74 
Properly return the available layers in the move layer response.
@petejohanson petejohanson added bug Something isn't working studio ZMK Studio (runtime keymaps) labels Jan 3, 2025
@petejohanson petejohanson self-assigned this Jan 3, 2025
@petejohanson petejohanson requested a review from a team as a code owner January 3, 2025 23:22
petejohanson
petejohanson commented Jan 4, 2025
View reviewed changes
Copy link
Contributor Author

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed by @ReFil on Discord.

@petejohanson petejohanson merged commit 36508c2 into zmkfirmware:main Jan 4, 2025
48 checks passed
@petejohanson petejohanson mentioned this pull request Jan 4, 2025
Open
ReFil pushed a commit to ReFil/zmk that referenced this pull request Jan 4, 2025
@petejohanson @ReFil
fix(studio): Allow adding layers after a layer move (zmkfirmware#2748)
8216ed4 
Properly return the available layers in the move layer response.
caksoylar pushed a commit to caksoylar/zmk that referenced this pull request Jan 11, 2025
@petejohanson @caksoylar
fix(studio): Allow adding layers after a layer move (zmkfirmware#2748)
9e3086b 
Properly return the available layers in the move layer response.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petejohanson petejohanson

Labels
bug Something isn't working studio ZMK Studio (runtime keymaps)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@petejohanson