Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combos): Properly report combos len with emply block #2739

Merged
merged 1 commit into from
Jan 1, 2025
Merged

fix(combos): Properly report combos len with emply block #2739

merged 1 commit into from
Jan 1, 2025

Conversation

petejohanson
Copy link
Contributor

@petejohanson petejohanson commented Jan 1, 2025 •
edited
Loading

Handle the scenario where there is an empty combos block and return a zero combos length.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@petejohanson
fix(combos): Properly report combos len with emply block
3ecb9c2 
Handle the scenario where there is an empty combos block and return
a zero combos length.
@petejohanson petejohanson added bug Something isn't working combos labels Jan 1, 2025
@petejohanson petejohanson self-assigned this Jan 1, 2025
@petejohanson petejohanson requested a review from a team as a code owner January 1, 2025 23:00
@petejohanson petejohanson merged commit f0a77b8 into zmkfirmware:main Jan 1, 2025
44 checks passed
@petejohanson petejohanson mentioned this pull request Jan 1, 2025
Open
caksoylar pushed a commit to caksoylar/zmk that referenced this pull request Jan 11, 2025
@petejohanson @caksoylar
fix(combos): Properly report combos len with emply block (zmkfirmware…
bf8555c 
…#2739)

Handle the scenario where there is an empty combos block and return
a zero combos length.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petejohanson petejohanson

Labels
bug Something isn't working combos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@petejohanson