Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the sound effects generation #207

Open
kemenaran opened this issue Apr 6, 2020 · 2 comments
Open

Document the sound effects generation #207

kemenaran opened this issue Apr 6, 2020 · 2 comments
Labels
audio issue related to the audio code help wanted contributions gladly accepted

Comments

@kemenaran
Copy link
Collaborator

Sounds effects (i.e. jingles, waveform-based sfx and noise-based sfx) are generated in https://github.com/zladx/LADX-Disassembly/blob/master/src/code/audio/sfx.asm.

The format seems pretty straightforward; probably no op-codes are involved. Still, the code needs documentation, and at least labeling of the different sound effects.

@kemenaran kemenaran added enhancement help wanted contributions gladly accepted labels Apr 6, 2020
@kemenaran kemenaran changed the title [audio] Document the sound effects generation Document the sound effects generation Apr 23, 2020
@kemenaran kemenaran added the audio issue related to the audio code label Apr 23, 2020
@Vextrove
Copy link
Contributor

Vextrove commented May 12, 2020

There are entries missing for a few IDs in hJingle and hNoiseSfx.
Shall I take a look if there are any missing sounds?

The system for sounds is similar to the system for music tracks. There's an address where you write an ID to play a track/sound, and then that ID gets copied to other addresses and the PlayMusicTrack address gets emptied.

@kemenaran
Copy link
Collaborator Author

Sure, if you can document the missing sounds and jingles, that'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio issue related to the audio code help wanted contributions gladly accepted
Projects
None yet
Development

No branches or pull requests

2 participants