Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make weth bridge addresses optional #190

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

Romsters
Copy link
Contributor

@Romsters Romsters commented Jul 9, 2024

What πŸ’»

Use erc20 bridge addresses if weth bridge addresses are not present.

Why βœ‹

Currently weth bridge addresses are required, and getL1BridgeContracts/getL2BridgeContracts function fails.

Evidence πŸ“·

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes πŸ“

This should fix deposits to the chains with custom base token.

@Romsters Romsters merged commit ce56b44 into ethers-v5 Jul 9, 2024
5 checks passed
@danijelTxFusion danijelTxFusion deleted the make-weth-bridge-optional-v5 branch July 9, 2024 11:48
github-actions bot pushed a commit that referenced this pull request Jul 9, 2024
## [5.9.1](v5.9.0...v5.9.1) (2024-07-09)

### Bug Fixes

* make weth bridge addresses optional ([#190](#190)) ([ce56b44](ce56b44))
Copy link

github-actions bot commented Jul 9, 2024

πŸŽ‰ This PR is included in version 5.9.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants