Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miette-derive syn dependency to syn 2 #243

Closed
jtroo opened this issue Mar 19, 2023 · 2 comments
Closed

Update miette-derive syn dependency to syn 2 #243

jtroo opened this issue Mar 19, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jtroo
Copy link
Contributor

jtroo commented Mar 19, 2023

Syn 2 was released recently and some crates, e.g. thiserror, are already migrated. To reduce clean compile times, should upgrade dependency to syn 2.

@jtroo jtroo changed the title Upgrade miette-derive dependency to syn 2 Update miette-derive syn dependency to syn 2 Mar 19, 2023
@zkat
Copy link
Owner

zkat commented Mar 19, 2023

You wanna send me a PR for this? :)

@zkat zkat added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 19, 2023
@jtroo
Copy link
Contributor Author

jtroo commented Mar 19, 2023

Doing a few minutes of investigation, it looks like it's a nontrivial change, to be expected since it's a major version update. It also looks like some tests are failing, just having checked out the code without trying to upgrade version yet, so that might be an issue with testing changes. I'll see how it goes when I find more time, no promises though 😅

Edit: ah I didn't realize I needed to enable all features to get tests to pass. Interesting.

@jtroo jtroo mentioned this issue Mar 29, 2023
@zkat zkat closed this as completed in a215720 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants