-
Notifications
You must be signed in to change notification settings - Fork 8
Adding short names case to fetcher test #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update test utility logic for join configuration construction and event DataFrame column selection. The modifications switch from dropping columns by name pattern to explicit column selection, refactor join configuration building to a fluent style with clearer naming and explicit options, and adjust prefix usage in a fetcher request and related tests. Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)spark/src/test/scala/ai/chronon/spark/test/fetcher/FetcherFailureTest.scala (8)⏰ Context from checks skipped due to timeout of 90000ms (16)
🔇 Additional comments (1)
|
e723743 to
91c13d2
Compare
Summary
Modifying one of the fetcher tests to user short names
Checklist
Summary by CodeRabbit