fix: check for table reachability first

[tchow-zlai]

Summary

• This change got left out of chore: Remove use of DelegatingTable and bubble up exceptions properly #638, we need to protect against NoSuchTableException now.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling to prevent issues when accessing unreachable tables, ensuring the system returns an empty result instead of failing.

[coderabbitai]

Walkthrough

A guard clause was introduced at the beginning of the partitions method in TableUtils.scala. This clause checks if a table is reachable and, if not, returns an empty list immediately, preventing further processing. No changes were made to method signatures or to the rest of the method's logic.

Changes

File(s)	Change Summary
spark/src/main/scala/ai/chronon/spark/TableUtils.scala	Added a guard clause in the partitions method to return early if the table is unreachable.

Possibly related PRs

• Change tableReachable log to info because WARN doesn't show up on etsy #352: Modifies logging within the tableReachable method, indicating both PRs involve changes related to tableReachable in TableUtils.scala.

Suggested reviewers

• david-zlai
• piyush-zlai
• nikhil-zlai

Poem

If the table can’t be found,
We won’t let errors abound.
A guard stands tall,
Returning nothing at all,
Keeping our code safe and sound!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 6b482ea and e3a2da9.

📒 Files selected for processing (1)

• spark/src/main/scala/ai/chronon/spark/TableUtils.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: streaming_tests
• GitHub Check: streaming_tests
• GitHub Check: groupby_tests
• GitHub Check: fetcher_tests
• GitHub Check: analyzer_tests
• GitHub Check: analyzer_tests
• GitHub Check: spark_tests
• GitHub Check: spark_tests
• GitHub Check: join_tests
• GitHub Check: join_tests
• GitHub Check: fetcher_tests
• GitHub Check: groupby_tests
• GitHub Check: batch_tests
• GitHub Check: batch_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (1)

spark/src/main/scala/ai/chronon/spark/TableUtils.scala (1)

183-183: The guard clause is a solid improvement.

Consistent with other methods in the class (e.g. allPartitions and containsPartitions), this check prevents unnecessary processing when a table isn't reachable.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tchow-zlai]

Job fa3cf809-3ed5-4b15-afc4-00d907e85c2c is in DONE state.
+ fail_if_bash_failed
+ '[' 0 -ne 0 ']'
++ cat tmp_metadata_upload.out
++ grep 'Dataproc submitter job id'
++ cut -d ' ' -f5
+ METADATA_UPLOAD_JOB_ID=fa3cf809-3ed5-4b15-afc4-00d907e85c2c
+ echo -e '\033[0;32m<<<<<.....................................FETCH.....................................>>>>>\033[0m'
<<<<<.....................................FETCH.....................................>>>>>
+ touch tmp_fetch.out
+ [[ dev == \c\a\n\a\r\y ]]
+ CUSTOMER_ID=dev
+ zipline run --repo=/Users/thomaschow/zipline-ai/chronon/api/python/test/canary --version 0.1.0+dev.thomaschow --mode fetch --conf=compiled/group_bys/gcp/purchases.v1_dev -k '{"user_id":"5"}' --name gcp.purchases.v1_dev
+ tee tmp_fetch.out
+ grep -q purchase_price_average_14d
+ fail_if_bash_failed
+ '[' 0 -ne 0 ']'
+ cat tmp_fetch.out
+ grep purchase_price_average_14d
  "purchase_price_average_14d" : 72.5,
+ '[' 0 -ne 0 ']'
+ echo -e '\033[0;32m<<<<<.....................................SUCCEEDED!!!.....................................>>>>>\033[0m'
<<<<<.....................................SUCCEEDED!!!.....................................>>>>>```