fix: handle nulls in transpose

[ken-zlai]

Summary

We need to make sure no nulls get passed thru the transpose method. should wrap up this ticket: https://app.asana.com/0/1208277377735902/1209343355165466

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Bug Fixes
  • Enhanced error handling ensures that invalid or missing values are consistently processed, leading to more reliable data outcomes.
• Tests
  • Added test cases to validate the updated handling of null and non-numeric values, ensuring robustness in data processing.

[coderabbitai]

Walkthrough

The changes improve error handling in PivotUtils.scala by updating the transpose method to check for null and NaN values, replacing them with a magic constant. Additionally, a new test in PivotUtilsTest.scala ensures that null values in percentile lists are correctly substituted, without affecting public interfaces.

Changes

File(s)	Change Summary
online/.../PivotUtils.scala	Updated transpose method to check if the list is null or if retrieved values are null/NaN, replacing them with Constants.magicNullDouble.
online/.../PivotUtilsTest.scala	Added a test case to validate that null values in percentile arrays are replaced with Constants.magicNullDouble.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Transpose
    Caller->>Transpose: Call transpose(list, pctIndex)
    alt list is null
        Transpose-->>Caller: Return null
    else list is not null
        Transpose->>Transpose: Retrieve value at pctIndex
        alt value is null or NaN
            Transpose-->>Caller: Return Constants.magicNullDouble
        else value is valid
            Transpose-->>Caller: Return value
        end
    end

Loading

Possibly related PRs

• fix: handle Infinity/NaN values in drift series #281: Updates error handling with Constants.magicNullDouble for invalid numeric values.
• fix: handle change to collectDoubles in convertTileDriftSeriesInfoToTimeSeries #293: Enhances null checks in conversion functions, aligning with similar null handling.
• fix: null pointer exception on some columns #341: Modifies null replacement in merge methods, providing consistency in handling nulls.

Suggested reviewers

• nikhil-zlai
• varant-zlai

Poem

In code's dance, a pivot refined,
Nulls and NaNs now clearly defined.
A magic constant fills the void,
Ensuring data's not destroyed.
A merry fix in each line deployed!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 32d9082 and bbec0fb.

📒 Files selected for processing (2)

• online/src/main/scala/ai/chronon/online/stats/PivotUtils.scala (1 hunks)
• online/src/test/scala/ai/chronon/online/test/stats/PivotUtilsTest.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: scala_compile_fmt_fix
• GitHub Check: non_spark_tests
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (2)

online/src/main/scala/ai/chronon/online/stats/PivotUtils.scala (1)

47-56: LGTM! Robust null handling implementation.

The changes correctly handle both null values and NaN doubles by replacing them with magicNullDouble.

online/src/test/scala/ai/chronon/online/test/stats/PivotUtilsTest.scala (1)

171-192: LGTM! Comprehensive test coverage.

Test thoroughly validates null handling in percentiles lists, ensuring they're correctly replaced with magicNullDouble.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sean-zlai]

LGTM. Thanks!