[Draft] CI cut over to Bazel #316

kumar-zlai · 2025-02-03T19:17:43Z

Summary

Checklist

Added Unit Tests
Covered by existing CI
Integration tested
Documentation update

Summary by CodeRabbit

Chores
- Updated internal testing workflows to improve efficiency, including a transition from SBT to Bazel for executing Flink tests.
- Removed previous installation steps for Bazel from the Dockerfile and replaced them with a more streamlined method, including the addition of necessary packages.
New Features
- The Scala library now includes enhanced JSON processing support with the addition of Jackson's Scala module, improving data handling capabilities.
Bug Fixes
- Added a verification step for Java installation in the testing workflow to ensure proper environment setup.

coderabbitai · 2025-02-03T19:17:53Z

Walkthrough

This PR updates the testing workflow for non-Spark Scala modules by replacing the SBT command for Flink tests with a Bazel command and removing associated SBT memory settings. Additionally, a new Jackson Scala JSON processing dependency is added to the Scala library configuration in the Bazel build file. The Dockerfile is modified to streamline the Bazel installation process.

Changes

Files	Change Summary
`.github/workflows/test_scala_no_spark.yaml`	Replaced SBT command with `bazel test //flink:test`; removed SBT_OPTS settings for Flink tests and added Java verification steps.
`online/BUILD.bazel`	Added dependency: `scala_artifact("com.fasterxml.jackson.module:jackson-module-scala")` to the `scala_library` target named `lib`.
`.github/image/Dockerfile`	Removed Bazel installation steps; added Bazelisk binary directly to `/usr/local/bin` and set executable permissions.

Possibly related PRs

Bazel migration for Flink module #237: Involves migrating the Flink module to Bazel, related to the testing changes in this PR.
feat: upgrade artifact upload to use bazel #314: Focuses on migrating processes to utilize Bazel, reflecting a shift in workflows similar to this PR.
Bazel migration for spark module #196: Updates dependencies in online/BUILD.bazel, related to the Jackson library changes in this PR.

Suggested reviewers

nikhil-zlai
piyush-zlai

Poem

In the realm of code so bright,
Bazel takes the testing flight.
SBT is now out of view,
Jackson adds a shiny new cue.
🎉 Cheers to change and coding delight!
Keep the workflow light and true.

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 56e627b and 0ca4d29.

📒 Files selected for processing (1)

.github/workflows/test_scala_no_spark.yaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/test_scala_no_spark.yaml

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tchow-zlai · 2025-02-03T19:19:24Z

online/BUILD.bazel

        maven_artifact("com.github.ben-manes.caffeine:caffeine"),
        maven_artifact("com.fasterxml.jackson.core:jackson-core"),
        maven_artifact("com.fasterxml.jackson.core:jackson-databind"),
+        scala_artifact("com.fasterxml.jackson.module:jackson-module-scala"),


also have this change here: https://github.com/zipline-ai/chronon/pull/314/files#diff-f522d0c899355e9fc9926756e546e22bd49c3fd46dc82af81220c0327f5357b2R21 but feel free to merge and I'll rebase

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/test_scala_no_spark.yaml (1)

46-50: Bazel cache mount is solid.
Consider a dynamic key for better cache invalidation.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between ff4e859 and 0c0982f.

📒 Files selected for processing (2)

.github/image/Dockerfile (0 hunks)
.github/workflows/test_scala_no_spark.yaml (1 hunks)

💤 Files with no reviewable changes (1)

.github/image/Dockerfile

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build-and-push

🔇 Additional comments (2)

.github/workflows/test_scala_no_spark.yaml (2)

44-44: Bazelisk setup added; looks good.

57-59: Flink tests now use Bazel; correct update.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/test_scala_no_spark.yaml (1)

45-50: Update setup-java version.
The action actions/setup-java@v3 is outdated; consider upgrading to v4.

🧰 Tools

🪛 actionlint (1.7.4)

46-46: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 0c0982f and 3a49fee.

📒 Files selected for processing (1)

.github/workflows/test_scala_no_spark.yaml (1 hunks)

🧰 Additional context used

🪛 actionlint (1.7.4)

.github/workflows/test_scala_no_spark.yaml

46-46: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🔇 Additional comments (3)

.github/workflows/test_scala_no_spark.yaml (3)

51-53: Bazel setup is fine.
Bazel step is added correctly.

54-59: Bazel cache step approved.
Caching Bazel at ~/.cache/bazel is correctly set up.

66-66: Flink tests command updated.
Using bazel test //flink:test meets the PR objectives.

kumar-zlai · 2025-02-04T18:02:53Z

No longer required as Nikhil has another PR out for the CI cut-over

Partial commit to test out flink tests using bazel

ff4e859

tchow-zlai reviewed Feb 3, 2025

View reviewed changes

Use bazelisk github action instead of manual install

0c0982f

coderabbitai bot reviewed Feb 3, 2025

View reviewed changes

Set up different java env for bazel

3a49fee

coderabbitai bot reviewed Feb 3, 2025

View reviewed changes

kumar-zlai and others added 5 commits February 3, 2025 12:03

Install bazel with the docker container

c9c98c0

Add new step to verify java installation for bazel

18fd6d2

Set environment variable for libjvm.so

7c16f48

Install gcc, g++ packages needed for bazel

56e627b

Add rule to print ld_library_path for debugging

0ca4d29

kumar-zlai closed this Feb 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Draft] CI cut over to Bazel #316

[Draft] CI cut over to Bazel #316

Uh oh!

kumar-zlai commented Feb 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 3, 2025 •

edited

Loading

Review ran into problems

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

tchow-zlai Feb 3, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

kumar-zlai commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Draft] CI cut over to Bazel #316

[Draft] CI cut over to Bazel #316

Uh oh!

Conversation

kumar-zlai commented Feb 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Review ran into problems

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

tchow-zlai Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

kumar-zlai commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kumar-zlai commented Feb 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)