-
Notifications
You must be signed in to change notification settings - Fork 8
Bazel migration for hub module #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
ca818de
router for vertx that maps pojo's and thrift objects
nikhil-zlai b5a4fdb
ci for router
nikhil-zlai b3230f6
enum support
nikhil-zlai 286d0fa
enum, map and list support
nikhil-zlai 61e26bb
test fixes, better error handling
nikhil-zlai 8bba81e
cleaned up redundant comments
nikhil-zlai 6a3e713
a few todos
nikhil-zlai b62d877
readme
nikhil-zlai e28ec33
lint
nikhil-zlai 2e7c6ed
support for binary serialization
nikhil-zlai 5b5c145
docs for binary serialization
nikhil-zlai e27b9c8
docs for javascript usage
nikhil-zlai 39b9259
map validation + formatting
nikhil-zlai 12683c9
caching setters
nikhil-zlai 65846d7
coderabbit nits
nikhil-zlai cc9ab7f
Build config for aggregator module
kumar-zlai c22461a
Minor fix to change naming convention for api module targets
kumar-zlai 0d8c084
Initial partial commit with CatalystHelper renaming
kumar-zlai 6d6dd6a
Initial partial commit with CatalystHelper renaming
kumar-zlai 7160500
Minor fix to update the naming convention for thrift targets
kumar-zlai b8d54e8
Partial commit with build config to merge changes from main
kumar-zlai fd4163a
Merge branch 'kumarteja/bazel-build' into kumarteja/online-bazel-migr…
kumar-zlai 6f3def4
working bazel build config for online module
kumar-zlai d4e34ee
Merge branch 'main' into kumarteja/online-bazel-migration
kumar-zlai e13ac8a
Minor changes to cleanup unused imports
kumar-zlai cb2b3fd
minor scalafixAll changes
kumar-zlai add315d
All spark targets working
kumar-zlai 5fea6d9
Initial working version with all spark targets
kumar-zlai 76c6f62
Merged with main branch
kumar-zlai cae2d80
Minor clean up of unused dependencies
kumar-zlai 0c8a955
Modified logging implementation dependency to match out sbt config
kumar-zlai feed133
merging with latest head
kumar-zlai e2acf6d
renamed to service_common package to avoid conflict with src root dir…
kumar-zlai c593729
Rename the service_common package back to service
91d6d9e
Addressed PR comments around handling response types
28d638e
Minor change to remove todo which is no longer needed
da2ff7f
Merge branch 'main' into kumarteja/spark-bazel-migration
kumar-zlai 9983609
Merge branch 'mead' into kumarteja/service-commons-bazel-migration
kumar-zlai 1b2ed5b
Merge branch 'mead' into kumarteja/service-commons-bazel-migration
kumar-zlai c545cc5
Initial working version along with unit tests
kumar-zlai 6630965
Merge branch 'main' into kumarteja/service-commons-bazel-migration
kumar-zlai 13182dd
Initial working version for src lib, tests pending
kumar-zlai 678a67c
merged with latest main branch
kumar-zlai 9dd1e09
test-lib build still not working
kumar-zlai dfe0e65
initial commit but test package not building
kumar-zlai da2b57c
Merged service_commons bazel migration branch
kumar-zlai e209d0f
Initial working version with unit tests
kumar-zlai 588d5dc
Initial working version without tests
kumar-zlai 1d03713
Merged for spark module minor fixes
kumar-zlai 0b506dc
Initial working version without tests
kumar-zlai 412e8ee
Merged with service module migration changes
kumar-zlai 5daa5e1
working version with unit tests
kumar-zlai 3076062
unit tests build working
kumar-zlai 1613377
test build succeeded but 3 of the tests are failing
kumar-zlai f449cbf
Merged with latest main branch
kumar-zlai 2e8fa95
Merged with latest main branch
kumar-zlai 1c153f2
Merged with latest main branch
kumar-zlai 03b985b
Merged with latest main
kumar-zlai a933223
merged with flink module changes to resolve conflicts later
kumar-zlai 5d4ad00
merged with cloud_gcp module changes to resolve econflicts later
kumar-zlai 90cc291
Merged with latest main
kumar-zlai b5d2216
Refactored common dependencies to remove duplication
kumar-zlai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| scala_library( | ||
| name = "lib", | ||
| srcs = glob(["src/main/**/*.scala"]) + glob(["src/main/**/*.java"]), | ||
| visibility = ["//visibility:public"], | ||
| deps = _VERTX_DEPS + _CIRCE_DEPS + [ | ||
| "//api:thrift", | ||
| "//api:lib", | ||
| "//online:lib", | ||
| "//service_commons:lib", | ||
| "//spark:lib", | ||
| scala_artifact("org.typelevel:cats-core"), | ||
| scala_artifact("com.chuusai:shapeless"), | ||
| scala_artifact("org.json4s:json4s-core"), | ||
| scala_artifact("org.json4s:json4s-jackson"), | ||
| scala_artifact("org.scala-lang.modules:scala-java8-compat"), | ||
| scala_artifact("org.scala-lang.modules:scala-collection-compat"), | ||
| maven_artifact("ch.qos.logback:logback-classic"), | ||
| maven_artifact("org.slf4j:slf4j-api"), | ||
| maven_artifact("com.typesafe:config"), | ||
| maven_artifact("io.netty:netty-all"), | ||
| maven_artifact("io.micrometer:micrometer-registry-statsd"), | ||
| maven_artifact("io.micrometer:micrometer-core"), | ||
| ], | ||
| ) | ||
|
|
||
| test_deps = _VERTX_TEST_DEPS + _CIRCE_DEPS + [ | ||
| ":lib", | ||
| "//api:thrift", | ||
| "//api:lib", | ||
| "//online:lib", | ||
| "//spark:lib", | ||
| "//service_commons:lib", | ||
| # Libraries | ||
| scala_artifact("org.typelevel:cats-core"), | ||
| scala_artifact("com.chuusai:shapeless"), | ||
| scala_artifact("org.scala-lang.modules:scala-java8-compat"), | ||
| scala_artifact("org.scala-lang.modules:scala-collection-compat"), | ||
| # Testing | ||
| scala_artifact("org.scalatest:scalatest-matchers-core"), | ||
| scala_artifact("org.scalatest:scalatest-core"), | ||
| scala_artifact("org.scalatest:scalatest"), | ||
| scala_artifact("org.scalatest:scalatest-flatspec"), | ||
| scala_artifact("org.scalatest:scalatest-funsuite"), | ||
| scala_artifact("org.scalatest:scalatest-shouldmatchers"), | ||
| scala_artifact("org.scalactic:scalactic"), | ||
| scala_artifact("org.scalatestplus:mockito-3-4"), | ||
| scala_artifact("org.mockito:mockito-scala"), | ||
| maven_artifact("org.mockito:mockito-core"), | ||
| maven_artifact("org.scalatest:scalatest-compatible"), | ||
| maven_artifact("junit:junit"), | ||
| maven_artifact("com.novocode:junit-interface"), | ||
| ] | ||
|
|
||
| scala_library( | ||
| name = "test-lib", | ||
| srcs = glob(["src/test/**/*.scala"]), | ||
| visibility = ["//visibility:public"], | ||
| deps = test_deps, | ||
| ) | ||
|
|
||
| scala_test_suite( | ||
| name = "test", | ||
| srcs = glob(["src/test/**/*.scala"]), | ||
| visibility = ["//visibility:public"], | ||
| deps = test_deps + [":test-lib"], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove duplicate dependency.
io.vertx:vertx-unit:4.5.10is already declared on line 92.- "io.vertx:vertx-unit:4.5.10",