Bazel migration for service module #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThis pull request introduces Bazel build configurations for a Java service, adding library and test suite targets in the Changes
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
service/BUILD.bazel (2)
26-45: Consider standardizing on JUnit 5.Both JUnit 4 (
junit:junit) and 5 (junit-jupiter-api) are included, which may cause confusion.
47-69: Reduce dependency duplication.Most dependencies are duplicated from test-lib. Consider moving common deps to test-lib.
flink/BUILD.bazel (2)
26-62: Consider organizing test dependencies.Similar to service/BUILD.bazel, consider moving common test dependencies to a central location.
64-101: Reduce dependency duplication.Dependencies are duplicated from test-lib. Consider referencing test-lib's deps instead.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (4)
flink/BUILD.bazel(1 hunks)service/BUILD.bazel(1 hunks)service/src/test/java/ai/chronon/service/handlers/FetchHandlerTest.java(5 hunks)tools/build_rules/dependencies/maven_repository.bzl(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- service/src/test/java/ai/chronon/service/handlers/FetchHandlerTest.java
🔇 Additional comments (3)
service/BUILD.bazel (1)
1-24: LGTM! Add tests as mentioned in PR description.Dependencies and configuration look correct for a Vert.x service.
tools/build_rules/dependencies/maven_repository.bzl (1)
60-68: LGTM! Dependencies are consistent.Flink and Vert.x versions are aligned across artifacts.
Also applies to: 76-76
flink/BUILD.bazel (1)
1-24: LGTM! Dependencies are well-organized.Flink streaming and core dependencies are properly configured.
nikhil-zlai
reviewed
Jan 21, 2025
Contributor
nikhil-zlai
left a comment
nikhil-zlai
left a comment
There was a problem hiding this comment.
refactor to re-use common array(s) of deps across targets.
piyush-zlai
approved these changes
Jan 21, 2025
| put("feature_2", 23.3); | ||
| put("feature_3", "USD"); | ||
| }}; | ||
| Map<String, Object> featureMap = new HashMap<>(Map.of( |
| add(mockResponse1); | ||
| add(mockResponse2); | ||
| }}; | ||
| List<JavaResponse> mockResponseList = new ArrayList<>(List.of( |
Contributor
There was a problem hiding this comment.
nit - just use list.of
Contributor
Author
done |
This was referenced Feb 1, 2025
4 tasks
kumar-zlai
added a commit
that referenced
this pull request
Apr 25, 2025
## Summary Migrated `service` module to Bazel from sbt. ## Checklist - [ ] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Build Configuration** - Added new Bazel targets for Java library and test suite - Configured dependencies for library and testing - **Test Improvements** - Updated test code to use more concise collection initialization methods - Simplified test code structure without changing functionality - **Dependency Management** - Added Vert.x Unit testing library version 4.5.10 <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: nikhil-zlai <[email protected]> Co-authored-by: Kumar Teja Chippala <[email protected]>
kumar-zlai
added a commit
that referenced
this pull request
Apr 29, 2025
## Summary Migrated `service` module to Bazel from sbt. ## Checklist - [ ] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Build Configuration** - Added new Bazel targets for Java library and test suite - Configured dependencies for library and testing - **Test Improvements** - Updated test code to use more concise collection initialization methods - Simplified test code structure without changing functionality - **Dependency Management** - Added Vert.x Unit testing library version 4.5.10 <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: nikhil-zlai <[email protected]> Co-authored-by: Kumar Teja Chippala <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary Migrated `service` module to Bazel from sbt. ## Checklist - [ ] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Build Configuration** - Added new Bazel targets for Java library and test suite - Configured dependencies for library and testing - **Test Improvements** - Updated test code to use more concise collection initialization methods - Simplified test code structure without changing functionality - **Dependency Management** - Added Vert.x Unit testing library version 4.5.10 <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: nikhil-zlai <[email protected]> Co-authored-by: Kumar Teja Chippala <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 15, 2025
## Summary Migrated `service` module to Bazel from sbt. ## Checklist - [ ] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Build Configuration** - Added new Bazel targets for Java library and test suite - Configured dependencies for library and testing - **Test Improvements** - Updated test code to use more concise collection initialization methods - Simplified test code structure without changing functionality - **Dependency Management** - Added Vert.x Unit testing library version 4.5.10 <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: nikhil-zlai <[email protected]> Co-authored-by: Kumar Teja Chippala <[email protected]>
chewy-zlai
pushed a commit
that referenced
this pull request
May 16, 2025
## Summary Migrated `service` module to Bazel from sbt. ## Cheour clientslist - [ ] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Build Configuration** - Added new Bazel targets for Java library and test suite - Configured dependencies for library and testing - **Test Improvements** - Updated test code to use more concise collection initialization methods - Simplified test code structure without changing functionality - **Dependency Management** - Added Vert.x Unit testing library version 4.5.10 <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: nikhil-zlai <[email protected]> Co-authored-by: Kumar Teja Chippala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated
servicemodule to Bazel from sbt.Checklist
Summary by CodeRabbit
Build Configuration
Test Improvements
Dependency Management