fix: extract out materialization props

[tchow-zlai]

Summary

Writing to bigquery partitioned tables involves creating bq temp table first. The temp table is created within the specified project + dataset of the destination table however we are running into an issue where the connector is unable to extract those information from the provided destination table id:

com.google.cloud.spark.bigquery.repackaged.com.google.inject.ProvisionException: Unable to provision, see the following errors:

1) [Guice/ErrorInCustomProvider]: IllegalArgumentException: Provided dataset is null or empty
  at BigQueryDataSourceWriterModule.provideDirectDataSourceWriterContext(BigQueryDataSourceWriterModule.java:63)
  while locating BigQueryDirectDataSourceWriterContext

so let's configure this as writeoptions on our side, which allows the connector to pick those up.

A successful run: https://console.cloud.google.com/dataproc/jobs/289ba1b4-b029-42b7-912d-4dad109f5dc9/monitoring?region=us-central1&project=canary-443022

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

Summary by CodeRabbit

• Refactor

  • Removed utility methods for table and database management in the application.
  • Simplified build configuration and dependency management.
  • Updated data writing configuration for improved integration with BigQuery.

• Chores

  • Minor formatting adjustments in build settings for improved readability.
  • Cleaned up commented dependencies.

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1209143482009694

[coderabbitai]

Walkthrough

The pull request involves modifications to the build.sbt file for dependency management and the TableUtils.scala file in the Spark module. The changes primarily focus on removing three utility methods (tableReachable, loadTable, and createDatabase) from the TableUtils class, indicating a significant reduction in the class's functionality related to table and database management. Additionally, the GcpFormatProvider.scala file has been updated to change the writeMethod option and enhance configuration parameters.

Changes

File	Change Summary
build.sbt	Minor formatting adjustments to dependency and assembly settings; removed commented-out SLF4J dependency
spark/src/main/scala/ai/chronon/spark/TableUtils.scala	Removed three methods: tableReachable(), loadTable(), and createDatabase()
cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala	Updated writeFormat method to change writeMethod from "indirect" to "direct" and added materializationProject and materializationDataset parameters

Possibly related PRs

• Add delta lake integration #51: The changes in build.sbt regarding dependency management and the addition of a new variable for Delta Spark are related to the main PR's focus on dependency management in build.sbt.
• feat: use log4j2 everywhere in spark consistently #99: The modifications to build.sbt for logging library dependencies are relevant as they also involve changes to the dependency management aspect of the project.
• feat: introduce BigQueryFormat #146: The updates to build.sbt for dependency management in the cloud_gcp project align with the main PR's focus on improving the organization of dependencies.

Suggested Reviewers

• piyush-zlai
• nikhil-zlai
• chewy-zlai

Poem

🔧 Farewell, old methods, clean and bright
Code trimmed down with surgical might
Build configs dance, dependencies sway
TableUtils slims down its way today!
Simplicity reigns, complexity takes flight 🚀

Warning

Review ran into problems

🔥 Problems

GitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 42ca88f and 55945aa.

📒 Files selected for processing (3)

• build.sbt (5 hunks)
• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala (1 hunks)
• spark/src/main/scala/ai/chronon/spark/TableUtils.scala (0 hunks)

💤 Files with no reviewable changes (1)

• spark/src/main/scala/ai/chronon/spark/TableUtils.scala

🚧 Files skipped from review as they are similar to previous changes (2)

• cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/GcpFormatProvider.scala
• build.sbt

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: fetcher_spark_tests
• GitHub Check: join_spark_tests

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tchow-zlai]

in later versions of the spark-bigquery connector, direct writes do support partitioned tables.