chore: remove unused thrift defs

[tchow-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Chores
  • Removed all references to physical nodes and tabular data from the orchestration API.
  • Streamlined the available node types and related data structures for a simplified user experience.
  • Expanded automated test workflows to run on all changes to the main branch, improving test coverage and reliability.
  • Removed lineage and node-related fields from job tracking and submission responses to simplify data handling.

[coderabbitai]

Walkthrough

The changes remove all Thrift API types and structures related to tabular data and physical nodes, including enums, structs, and union members. Only logical node types for stagingQuery, join, groupBy, and model remain in the API, with all references to tabular and physical node concepts eliminated. Additionally, GitHub Actions workflows for Python and Scala tests were modified to trigger on all pushes and pull requests to main, removing prior path-based filters.

Changes

Cohort / File(s)	Change Summary
Tabular Data Types Removal api/thrift/orchestration.thrift	Removed TabularDataType enum, TabularData struct, and tabularData from LogicalNode union.
Physical Node & Graph Types Removal api/thrift/orchestration.thrift	Deleted NodeKey, NodeInfo, NodeConnections, NodeGraph, all physical node enums, PhysicalNodeType union, PhysicalNode, PhysicalGraph, and PhysicalNodeKey.
Logical Node Simplification api/thrift/orchestration.thrift	LogicalNode now only includes stagingQuery, join, groupBy, and model members.
Lineage & Submission Struct Updates api/thrift/hub.thrift	Removed LineageResponse struct; removed mainNode from JobTrackerResponse; removed node from Submission.
Workflow Trigger Broadening .github/workflows/test_python.yaml, .github/workflows/test_scala_2_12_non_spark.yaml, .github/workflows/test_scala_fmt.yaml	Removed path filters on push and pull_request events; workflows now run on any change to main.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~40 minutes

Possibly related PRs

• stub/part_1: physical graph for workflow submission + column lineage #493: Introduces physical graph and node classes, opposite to this PR's removal of those types.
• Move common table info from TableDependency to a separate struct #568: Refactors internal structure of table dependency types removed here.

Suggested reviewers

• nikhil-zlai
• piyush-zlai

Poem

🚀
Out go the nodes, both graph and key,
Tabular dreams now history.
Enums and structs swept from sight,
The Thrift file trimmed, now lean and light.
Logical paths remain to see—
A simpler API, wild and free!
✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dcdc317 and 9887a07.

📒 Files selected for processing (1)

• api/thrift/hub.thrift (0 hunks)

💤 Files with no reviewable changes (1)

• api/thrift/hub.thrift

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch tchow/slim-thrift

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tchow-zlai]

cc @sean-zlai lmk if this is a safe change