chore: add ruff linter (#532)

## Summary

## Checklist
- [ ] Added Unit Tests
- [x] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Integrated a new linting tool into the development workflow for
improved code quality.

- **Refactor/Style**
- Streamlined and reorganized code structure by reordering import
statements and adjusting default parameters.
- Enhanced error handling to provide clearer diagnostics without
impacting functionality.

- **Chores**
- Updated configuration and build settings to standardize the codebase
and CI processes.
- Added a new configuration file for the Ruff linter, specifying linting
settings and rules.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: nikhil-zlai

.github/image/Dockerfile

@@ -56,7 +56,7 @@ RUN apt install -y \
     rm -rf /var/lib/apt/lists/*
 
 # Upgrade pip and install some common Python packages
-RUN pip3 install --break-system-packages pytest tox flake8
+RUN pip3 install --break-system-packages pytest tox flake8 ruff
 
 RUN apt update && apt install -y build-essential git
 RUN mkdir -p /usr/lib/jvm && ln -s /usr/lib/jvm/java-17-openjdk-amd64/ /usr/lib/jvm/default-jvm

.github/workflows/test_python.yaml

@@ -44,14 +44,22 @@ jobs:
           python3 -m venv chronon_py_env
           source chronon_py_env/bin/activate
 
-      - name: Run Chronon Python lint
+      - name: Run Chronon Python lint (flake8)
         shell: bash
         run: |
           source chronon_py_env/bin/activate
           cd api/py/ai/chronon
           pip install importlib-metadata==4.11.4
           pip install flake8
           flake8 --extend-ignore=W605,Q000,F631 --exclude=cli
+          
+      - name: Run Chronon Python lint (ruff)
+        shell: bash
+        run: |
+          source chronon_py_env/bin/activate
+          cd api/py
+          pip install ruff
+          ruff check .
 
       - name: Run Chronon Python tests
         shell: bash

api/py/ai/chronon/cli/compile/compile_context.py

@@ -1,18 +1,17 @@
-from dataclasses import dataclass
 import os
+from dataclasses import dataclass
 from typing import Any, Dict, List, Type
 
+import ai.chronon.cli.compile.parse_teams as teams
 from ai.chronon.api.common.ttypes import ConfigType
 from ai.chronon.api.ttypes import GroupBy, Join, StagingQuery, Team
-from ai.chronon.cli.compile.display.compiled_obj import CompiledObj
+from ai.chronon.cli.compile.conf_validator import ConfValidator
 from ai.chronon.cli.compile.display.compile_status import CompileStatus
+from ai.chronon.cli.compile.display.compiled_obj import CompiledObj
 from ai.chronon.cli.compile.serializer import file2thrift
-from ai.chronon.cli.compile.conf_validator import ConfValidator
-import ai.chronon.cli.compile.parse_teams as teams
-from ai.chronon.cli.logger import require, get_logger
+from ai.chronon.cli.logger import get_logger, require
 from ai.chronon.model import Model
 
-
 logger = get_logger()
 
 
@@ -129,7 +128,7 @@ def _parse_existing_confs(self, obj_class: type) -> Dict[str, object]:
         if not os.path.exists(output_dir):
             return result
 
-        for sub_root, sub_dirs, sub_files in os.walk(output_dir):
+        for sub_root, _sub_dirs, sub_files in os.walk(output_dir):
 
             for f in sub_files:
 

api/py/ai/chronon/cli/compile/compiler.py

@@ -1,18 +1,15 @@
-from dataclasses import dataclass
 import os
 import shutil
 import traceback
-from typing import Dict, Any, List, Optional, Tuple
-
-from ai.chronon.cli.compile.compile_context import CompileContext, ConfigInfo
+from dataclasses import dataclass
+from typing import Any, Dict, List, Optional, Tuple
 
-from ai.chronon.cli.compile.display.class_tracker import ClassTracker
 import ai.chronon.cli.compile.display.compiled_obj
-from ai.chronon.cli.compile.display.compiled_obj import CompiledObj
 import ai.chronon.cli.compile.parse_configs as parser
 import ai.chronon.cli.logger as logger
-
 from ai.chronon.api.common.ttypes import ConfigType
+from ai.chronon.cli.compile.compile_context import CompileContext, ConfigInfo
+from ai.chronon.cli.compile.display.compiled_obj import CompiledObj
 
 logger = logger.get_logger()
 

api/py/ai/chronon/cli/compile/conf_validator.py

@@ -17,26 +17,23 @@
 
 import json
 import logging
-import os
 import re
-import ai.chronon.api.common.ttypes as common
-import glom
-
+from collections import defaultdict
+from typing import Dict, List, Set
 
+import ai.chronon.api.common.ttypes as common
 from ai.chronon.api.ttypes import (
     Accuracy,
     Aggregation,
+    Derivation,
+    ExternalPart,
     GroupBy,
     Join,
     Source,
-    Derivation,
-    ExternalPart,
 )
 from ai.chronon.group_by import get_output_col_names
 from ai.chronon.logger import get_logger
 from ai.chronon.repo.serializer import thrift_simple_json
-from collections import defaultdict
-from typing import List, Dict, Set
 
 # Fields that indicate stutus of the entities.
 SKIPPED_FIELDS = frozenset(["metaData"])

api/py/ai/chronon/cli/compile/display/class_tracker.py

@@ -1,5 +1,6 @@
 import difflib
-from typing import Dict, List, Any
+from typing import Any, Dict, List
+
 from rich.text import Text
 
 from ai.chronon.cli.compile.display.compiled_obj import CompiledObj
@@ -79,7 +80,7 @@ def to_status(self) -> Text:
         if self.files_to_obj:
             text.append("  Compiled ")
             text.append(f"{len(self.new_objs)} ", style="bold green")
-            text.append(f"objects from ")
+            text.append("objects from ")
             text.append(f"{len(self.files_to_obj)} ", style="bold green")
             text.append("files.\n")
 

api/py/ai/chronon/cli/compile/display/compile_status.py

@@ -1,11 +1,11 @@
-from typing import Dict, List
+from collections import OrderedDict
+from typing import Dict
+
 from rich.live import Live
 from rich.text import Text
-from rich.console import Console
-from collections import OrderedDict
 
-from ai.chronon.cli.compile.display.compiled_obj import CompiledObj
 from ai.chronon.cli.compile.display.class_tracker import ClassTracker
+from ai.chronon.cli.compile.display.compiled_obj import CompiledObj
 
 
 class CompileStatus:

api/py/ai/chronon/cli/compile/display/diff_result.py

@@ -1,8 +1,6 @@
-from dataclasses import dataclass
-from typing import List, Dict
+from typing import List
+
 from rich.text import Text
-import difflib
-from ai.chronon.cli.compile.display.compiled_obj import CompiledObj
 
 
 class DiffResult:

api/py/ai/chronon/cli/compile/parse_configs.py

@@ -4,8 +4,8 @@
 from typing import List
 
 from ai.chronon.cli.compile import parse_teams, serializer
-from ai.chronon.cli.compile.display.compiled_obj import CompiledObj
 from ai.chronon.cli.compile.compile_context import CompileContext
+from ai.chronon.cli.compile.display.compiled_obj import CompiledObj
 from ai.chronon.cli.logger import get_logger
 
 logger = get_logger()

api/py/ai/chronon/cli/compile/parse_teams.py

@@ -1,14 +1,15 @@
-from copy import deepcopy
 import importlib
 import os
+from copy import deepcopy
+from typing import Any, Dict, List, Union
+
 from ai.chronon.api.common.ttypes import (
-    ExecutionInfo,
     ConfigProperties,
     EnvironmentVariables,
+    ExecutionInfo,
 )
 from ai.chronon.api.ttypes import Team
 from ai.chronon.cli.logger import get_logger, require
-from typing import Any, List, Dict, Union
 
 logger = get_logger()