Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: in_memory_html/localstorage exception #717

Closed
christophemacabiau opened this issue Aug 27, 2020 · 3 comments
Closed

web: in_memory_html/localstorage exception #717

christophemacabiau opened this issue Aug 27, 2020 · 3 comments
Labels
⌛ reproduction needed Issue is subtle and requires a true accessible reproduction to debug 👵 outdated Outdated and will be closed soon unless reproduced on the latest beta

Comments

@christophemacabiau
Copy link

Seems that when initializing the cache, we try to stringify this FutureOr:
https://github.com/zino-app/graphql-flutter/blob/f12aae525b1bf7fd5c3120a3a62bccd87cabad68/packages/graphql/lib/src/cache/in_memory_html.dart#L16
which produces masterKey="Instance of '_Future<String>'"

Later we try to find this key in localStorage:
https://github.com/zino-app/graphql-flutter/blob/f12aae525b1bf7fd5c3120a3a62bccd87cabad68/packages/graphql/lib/src/cache/in_memory_html.dart#L76
and we dont find it, but we try to jsonDecode it, which produces a Invalid argument: null exception

graphql_flutter 3.0.1
flutter 1.31.0-9.1.pre

@micimize
Copy link
Collaborator

micimize commented Oct 7, 2020

This is likely solved by HiveStore in 4.0.0-beta.1 (#648). Please give it a try and comment if there's still an issue

@micimize micimize added 👵 outdated Outdated and will be closed soon unless reproduced on the latest beta ⌛ reproduction needed Issue is subtle and requires a true accessible reproduction to debug labels Oct 7, 2020
@micimize
Copy link
Collaborator

double checked and this is solved on v4

@christophemacabiau
Copy link
Author

@micimize thanks, it works
sorry for the late answer, I forgot this isssue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌛ reproduction needed Issue is subtle and requires a true accessible reproduction to debug 👵 outdated Outdated and will be closed soon unless reproduced on the latest beta
Projects
None yet
Development

No branches or pull requests

2 participants