Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export operation and fetch_result in graphql_flutter.dart #487

Closed
Hauglid opened this issue Dec 11, 2019 · 5 comments
Closed

Export operation and fetch_result in graphql_flutter.dart #487

Hauglid opened this issue Dec 11, 2019 · 5 comments
Assignees
Labels
🐛 bug Something isn't working dart client Issue relates mainly to the standalone dart client link Relates to link functionality

Comments

@Hauglid
Copy link

Hauglid commented Dec 11, 2019

I have implemented my own authlink so that I can customise the header.
My IDE gives me a warning for the imports:
import 'package:graphql/src/link/operation.dart'; import 'package:graphql/src/link/fetch_result.dart';
Don't import implementation files from another package.dart(implementation_imports)

Please add them to graphql_flutter.dart exports.

@mainawycliffe mainawycliffe added 🐛 bug Something isn't working dart client Issue relates mainly to the standalone dart client labels Dec 11, 2019
@mainawycliffe mainawycliffe self-assigned this Dec 11, 2019
@mainawycliffe
Copy link
Collaborator

Can you try and import package:graphql/client.dart and see if it changes anything?

@Hauglid
Copy link
Author

Hauglid commented Dec 12, 2019

Didn't work since they are not a part of the client.dart exports.

@mainawycliffe
Copy link
Collaborator

Okay, I will PR this today, it's a simple change, once they are exported by the client.dart, then graphql flutter will pick them up automatically.

@mainawycliffe
Copy link
Collaborator

@Hauglid since #492 has been merged, you can try the next beta and check if this issue has been resolved. It is not released yet but will be automatically released in the next few of hours.

@klavs klavs added the link Relates to link functionality label Feb 16, 2020
@micimize
Copy link
Collaborator

micimize commented Oct 7, 2020

Outdated / Solved implicitly by core rework in 4.0.0-beta.1 #648

@micimize micimize closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working dart client Issue relates mainly to the standalone dart client link Relates to link functionality
Projects
None yet
Development

No branches or pull requests

4 participants