Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimistic mutation results #127

Closed
micimize opened this issue Oct 19, 2018 · 7 comments
Closed

Optimistic mutation results #127

micimize opened this issue Oct 19, 2018 · 7 comments
Assignees
Labels
enhancement New feature or request next Feature or report is related to next released
Milestone

Comments

@micimize
Copy link
Collaborator

micimize commented Oct 19, 2018

This depends on #114 - a naive implementation shouldn't be too difficult.
Steps for optimistic results would be:

Offline queue moved to #201:

@HofmannZ if #114 makes sense to you I'd like to start working on it in preparation to implement this

@HofmannZ
Copy link
Member

@micimize Yeah sounds good to me, need any help?

@HofmannZ HofmannZ added the enhancement New feature or request label Oct 28, 2018
@HofmannZ HofmannZ added this to the 1.0.0 milestone Oct 28, 2018
@HofmannZ HofmannZ added the next Feature or report is related to next label Oct 28, 2018
@HofmannZ HofmannZ changed the title [next] Optimistic mutation results, offline mutation queue Optimistic mutation results, offline mutation queue Oct 28, 2018
@micimize
Copy link
Collaborator Author

@HofmannZ possibly! I think I've just about completed the optimism chunk of this, continuing from #130 (although they're less entangled than I expected).

Here's a brain dump on the query rebroadcast logic, for posterity:
The solution I implemented is to just rebroadcast all safe queries from the cache on every optimistic update, preserving previous QueryResult state where it makes sense.

Apollo's solution, which may be more robust:

@eusdima eusdima closed this as completed Feb 16, 2019
@eusdima
Copy link
Contributor

eusdima commented Feb 16, 2019

Fixed by #130

@micimize
Copy link
Collaborator Author

this was not actually resolved - #114 was resolved, which was a dependency.

Here's a diff of the most recent work I've done on this

@micimize micimize reopened this Mar 19, 2019
@micimize micimize changed the title Optimistic mutation results, offline mutation queue Optimistic mutation results Mar 26, 2019
@micimize
Copy link
Collaborator Author

closed by #199

@HofmannZ
Copy link
Member

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HofmannZ
Copy link
Member

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next Feature or report is related to next released
Projects
None yet
Development

No branches or pull requests

3 participants