Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Exception in 4.0.0-alpha.10 #734

Closed
aseef17 opened this issue Sep 26, 2020 · 2 comments
Closed

Link Exception in 4.0.0-alpha.10 #734

aseef17 opened this issue Sep 26, 2020 · 2 comments
Assignees
@micimize
Labels
v4 Issue with a v4 library

Comments

@aseef17
Copy link

aseef17 commented Sep 26, 2020

Describe the issue
When trying to pass custom objects to variables, we get the following error

LinkException: LinkException('package:gql_http_link/src/_utils.dart': Failed assertion: line 75 pos 5: 'body is String || body is num || body == null'

Expected behavior
Custom objects should be allowed in variables. This worked fine in V 3.1.0

device / execution context
Are you on iOS, android, web, in a simulator, running from the terminal etc? This is especially important for localhost connection issues.
No.

Stacktrace: 
LinkException: LinkException('package:gql_http_link/src/_utils.dart': Failed assertion: line 75 pos 5: 'body is bool || body is String || body is num || body == null': Instance of 'OrderProduct' of type OrderProduct was found in in the request at path variables.products.0, but the only the types { Map, List, MultipartFile, bool, String, num, null } are allowed)
@aseef17 aseef17 added the v4 Issue with a v4 library label Sep 26, 2020
micimize added a commit that referenced this issue Sep 26, 2020
@micimize
fix(client): gql_http_link==0.3.2 for custom toJsons closing #734
98b8cf7
@micimize
Copy link
Collaborator

Right you are! Got rid of that assertion and should be solved in 4.0.0-alpha.11

@aseef17
Copy link
Author

aseef17 commented Sep 26, 2020

Right you are! Got rid of that assertion and should be solved in 4.0.0-alpha.11

Thanks for the quick response. I'll test it out and close the issue if it's fixed

@aseef17 aseef17 closed this as completed Sep 28, 2020
HofmannZ pushed a commit that referenced this issue Oct 7, 2020
@semantic-release-bot
chore(release): 4.0.0-beta.1 [skip ci]
8bea4ba 
# [4.0.0-beta.1](v3.1.0...v4.0.0-beta.1) (2020-10-07)

### Bug Fixes

* **examples:** ignore missing token ([ffd3294](ffd3294))
* query test ([f54c6ae](f54c6ae))
* **ci:** loosen path version ([645d462](645d462))
* **client:** gql_http_link==0.3.2 for custom toJsons closing [#734](#734) ([98b8cf7](98b8cf7))
* **client:** mutation not firing observer callbacks ([75393c2](75393c2))
* **client:** only queries are refetch safe ([1e93376](1e93376))
* **docs:** typo in docstring, add todo to sanitizeVariables ([9c84cb1](9c84cb1))
* **examples:** cleanup bloc example ([82724f0](82724f0))
* **examples:** flutter bloc pubspec ([61582b3](61582b3))
* **examples:** starwars example cache ([22db4f7](22db4f7))
* **examples:** starwars example works again ([7514b93](7514b93))
* **examples:** update ios files for graphql_flutter/example ([5b6e3d0](5b6e3d0))
* **graphql:** default-yet-overrideable variable ([6ba687e](6ba687e))
* **graphql:** don't close mutations after callbacks ([2ba6c74](2ba6c74))
* **graphql:** dumb ?? documentNode bug ([ba7b641](ba7b641))
* **graphql:** fix rebroadcasting by refactoring onData callbacks into a simpler async function ([9a5fff1](9a5fff1))
* **graphql:** keep deprecated QueryResult api and mark it as such ([2b447a0](2b447a0))
* **graphql:** sanitize multipart files for cache ([4ceb800](4ceb800))
* **graphql:** simplified AuthLink ([0b3fbd9](0b3fbd9))
* **tests:** update tests ([bba4a7a](bba4a7a))

### Features

* cache now flags itself for broadcasting ([84cba43](84cba43))
* client.fetchMore utility for leveraging the fetch more logic results without using ObservableQuery ([814ccb3](814ccb3))
* documentNode -> document, dependency issues, reexport links from client (for now), retrieve subscription changes from [#533](#533) ([4fb205c](4fb205c))
* **graphql_flutter:** add ResultAccumulator, fix Subscription ([7e1edee](7e1edee))
* drop Link layer in favor of package:gql_link and package:gql_exec ([2e491a7](2e491a7))
* **client:** cache proxy methods on cache, resetStore with optional refetchQueries ([ba7134a](ba7134a))
* **client:** expose store, cleanup ([6fc5e7e](6fc5e7e))
* **client:** refetchSafeQueries, clarify rebroadcast calls in docs ([e45b240](e45b240))
* **docs:** v4 changelog ([38cfd9b](38cfd9b))
* **examples:** reorg graphql example so pub displays code ([bc32bdd](bc32bdd))
* **examples:** starwars hivestore usage ([2f874ec](2f874ec))
* **graphql:** add isMutation etc helpers to Options types ([04e7888](04e7888))
* **graphql:** complete caching overhaul ([e9b5660](e9b5660))
* **graphql:** HiveStore api improvements, fetchmore fixes ([2d1a7f2](2d1a7f2))
* **graphql:** HiveStore.open ([6db4677](6db4677))
* **graphql:** multipart file support ([c2733ca](c2733ca))
* **graphql:** re-add documentNode asdeprecated ([20d0176](20d0176))
* **graphql:** Robust ObservableQuery docs ([1e893b5](1e893b5))
* **graphql:** update old websocket_link ([496d994](496d994))
* **graphql:** use new cache correctly everywhere else ([f64a6c8](f64a6c8))
* HiveStore ([2c3c66c](2c3c66c))
* more work on gql links ([0d7ef7a](0d7ef7a))
* move to DocumentNode-only documents ([7499323](7499323))
* starting on gql links ([d9452bc](d9452bc))
* **graphql:** work on making subscriptions more of a first-class citizen ([6d0b045](6d0b045))
* **graphql_flutter:** initHiveForFlutter ([1118cc7](1118cc7))
* **graphql_flutter:** work on making subscriptions more of a first-class citizen ([a0e0d5c](a0e0d5c))
* **tests:** test subscriptions ([2a3e6a1](2a3e6a1))

### BREAKING CHANGES

* the deprecated string documents are no longer supported
* Link layer is now implemented via package:gql_link and package:gql_exec
HofmannZ pushed a commit that referenced this issue Jan 31, 2021
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
48598b7 
# [4.0.0](v3.1.0...v4.0.0) (2021-01-31)

### Bug Fixes

* **examples:** starwars example cache ([22db4f7](22db4f7))
* fix ObservableQuery.lifecycle for cache only results ([f44b479](f44b479))
* **client:** mutation not firing observer callbacks ([75393c2](75393c2))
* query test ([f54c6ae](f54c6ae))
* **ci:** loosen path version ([645d462](645d462))
* **client:** add CacheMissException for when write/read results in null ([a0a967f](a0a967f))
* **client:** fetchMore partial handling ([10ec576](10ec576))
* **client:** gql_http_link==0.3.2 for custom toJsons closing [#734](#734) ([98b8cf7](98b8cf7))
* **client:** only queries are refetch safe ([1e93376](1e93376))
* **client:** refetch overrides fetchPolicy ([891bc2b](891bc2b))
* **client:** skip cache writes on null data, thus fixing [#405](#405) ([7472bb9](7472bb9))
* **client:** wrap all subscription errors in QueryResults ([aae61ca](aae61ca))
* **docs:** typo in docstring, add todo to sanitizeVariables ([9c84cb1](9c84cb1))
* **examples:** cleanup bloc example ([82724f0](82724f0))
* **examples:** flutter bloc pubspec ([61582b3](61582b3))
* **examples:** ignore missing token ([ffd3294](ffd3294))
* **examples:** starwars example works again ([7514b93](7514b93))
* **examples:** update ios files for graphql_flutter/example ([5b6e3d0](5b6e3d0))
* **graphql:** default-yet-overrideable variable ([6ba687e](6ba687e))
* **graphql:** don't close mutations after callbacks ([2ba6c74](2ba6c74))
* **graphql:** dumb ?? documentNode bug ([ba7b641](ba7b641))
* **graphql:** fix rebroadcasting by refactoring onData callbacks into a simpler async function ([9a5fff1](9a5fff1))
* **graphql:** keep deprecated QueryResult api and mark it as such ([2b447a0](2b447a0))
* **graphql:** sanitize multipart files for cache ([4ceb800](4ceb800))
* **graphql:** simplified AuthLink ([0b3fbd9](0b3fbd9))
* **tests:** update tests ([bba4a7a](bba4a7a))

### Features

* cache now flags itself for broadcasting ([84cba43](84cba43))
* client.fetchMore utility for leveraging the fetch more logic results without using ObservableQuery ([814ccb3](814ccb3))
* documentNode -> document, dependency issues, reexport links from client (for now), retrieve subscription changes from [#533](#533) ([4fb205c](4fb205c))
* **graphql:** HiveStore.open ([6db4677](6db4677))
* drop Link layer in favor of package:gql_link and package:gql_exec ([2e491a7](2e491a7))
* **client:** add context to QueryResult ([fbc5a2d](fbc5a2d))
* **client:** cache proxy methods on cache, resetStore with optional refetchQueries ([ba7134a](ba7134a))
* **client:** cache writes are now strict, and throw PartialDataException (from normalize), ([616b5ed](616b5ed))
* **client:** CacheRereadPolicy, watchMutation workaround ([32e02da](32e02da))
* **client:** carry forward data on exception ([ccf3b9c](ccf3b9c))
* **client:** expose store, cleanup ([6fc5e7e](6fc5e7e))
* **client:** only rebroadcast on deep equals ([ee64e99](ee64e99))
* **client:** partialDataPolicy for configuring rejections ([0a7cd28](0a7cd28))
* **client:** QueryResult.unexecuted ([13e3257](13e3257))
* **client:** refetchSafeQueries, clarify rebroadcast calls in docs ([e45b240](e45b240))
* **docs:** v4 changelog ([38cfd9b](38cfd9b))
* **examples:** reorg graphql example so pub displays code ([bc32bdd](bc32bdd))
* **examples:** starwars hivestore usage ([2f874ec](2f874ec))
* **graphql:** add isMutation etc helpers to Options types ([04e7888](04e7888))
* **graphql:** complete caching overhaul ([e9b5660](e9b5660))
* **graphql:** HiveStore api improvements, fetchmore fixes ([2d1a7f2](2d1a7f2))
* **graphql:** multipart file support ([c2733ca](c2733ca))
* **graphql:** re-add documentNode asdeprecated ([20d0176](20d0176))
* more work on gql links ([0d7ef7a](0d7ef7a))
* **graphql:** Robust ObservableQuery docs ([1e893b5](1e893b5))
* **graphql:** update old websocket_link ([496d994](496d994))
* **graphql:** upgrade normalize to 0.4.2 ([4655e7d](4655e7d))
* **graphql:** use new cache correctly everywhere else ([f64a6c8](f64a6c8))
* starting on gql links ([d9452bc](d9452bc))
* **graphql:** work on making subscriptions more of a first-class citizen ([6d0b045](6d0b045))
* **graphql_flutter:** add ResultAccumulator, fix Subscription ([7e1edee](7e1edee))
* **graphql_flutter:** initHiveForFlutter ([1118cc7](1118cc7))
* HiveStore ([2c3c66c](2c3c66c))
* move to DocumentNode-only documents ([7499323](7499323))
* **graphql_flutter:** work on making subscriptions more of a first-class citizen ([a0e0d5c](a0e0d5c))
* **tests:** test subscriptions ([2a3e6a1](2a3e6a1))

### BREAKING CHANGES

* **client:** By fixing the defaults for mutations, the old behavior
is now lost
* the deprecated string documents are no longer supported
* Link layer is now implemented via package:gql_link and package:gql_exec
micimize pushed a commit that referenced this issue Jan 31, 2021
@semantic-release-bot @micimize
chore(release): 4.0.0 [skip ci]
9f8673c 
# [4.0.0](v3.1.0...v4.0.0) (2021-01-31)

### Bug Fixes

* **examples:** starwars example cache ([22db4f7](22db4f7))
* fix ObservableQuery.lifecycle for cache only results ([f44b479](f44b479))
* **client:** mutation not firing observer callbacks ([75393c2](75393c2))
* query test ([f54c6ae](f54c6ae))
* **ci:** loosen path version ([645d462](645d462))
* **client:** add CacheMissException for when write/read results in null ([a0a967f](a0a967f))
* **client:** fetchMore partial handling ([10ec576](10ec576))
* **client:** gql_http_link==0.3.2 for custom toJsons closing [#734](#734) ([98b8cf7](98b8cf7))
* **client:** only queries are refetch safe ([1e93376](1e93376))
* **client:** refetch overrides fetchPolicy ([891bc2b](891bc2b))
* **client:** skip cache writes on null data, thus fixing [#405](#405) ([7472bb9](7472bb9))
* **client:** wrap all subscription errors in QueryResults ([aae61ca](aae61ca))
* **docs:** typo in docstring, add todo to sanitizeVariables ([9c84cb1](9c84cb1))
* **examples:** cleanup bloc example ([82724f0](82724f0))
* **examples:** flutter bloc pubspec ([61582b3](61582b3))
* **examples:** ignore missing token ([ffd3294](ffd3294))
* **examples:** starwars example works again ([7514b93](7514b93))
* **examples:** update ios files for graphql_flutter/example ([5b6e3d0](5b6e3d0))
* **graphql:** default-yet-overrideable variable ([6ba687e](6ba687e))
* **graphql:** don't close mutations after callbacks ([2ba6c74](2ba6c74))
* **graphql:** dumb ?? documentNode bug ([ba7b641](ba7b641))
* **graphql:** fix rebroadcasting by refactoring onData callbacks into a simpler async function ([9a5fff1](9a5fff1))
* **graphql:** keep deprecated QueryResult api and mark it as such ([2b447a0](2b447a0))
* **graphql:** sanitize multipart files for cache ([4ceb800](4ceb800))
* **graphql:** simplified AuthLink ([0b3fbd9](0b3fbd9))
* **tests:** update tests ([bba4a7a](bba4a7a))

### Features

* cache now flags itself for broadcasting ([84cba43](84cba43))
* client.fetchMore utility for leveraging the fetch more logic results without using ObservableQuery ([814ccb3](814ccb3))
* documentNode -> document, dependency issues, reexport links from client (for now), retrieve subscription changes from [#533](#533) ([4fb205c](4fb205c))
* **graphql:** HiveStore.open ([6db4677](6db4677))
* drop Link layer in favor of package:gql_link and package:gql_exec ([2e491a7](2e491a7))
* **client:** add context to QueryResult ([fbc5a2d](fbc5a2d))
* **client:** cache proxy methods on cache, resetStore with optional refetchQueries ([ba7134a](ba7134a))
* **client:** cache writes are now strict, and throw PartialDataException (from normalize), ([616b5ed](616b5ed))
* **client:** CacheRereadPolicy, watchMutation workaround ([32e02da](32e02da))
* **client:** carry forward data on exception ([ccf3b9c](ccf3b9c))
* **client:** expose store, cleanup ([6fc5e7e](6fc5e7e))
* **client:** only rebroadcast on deep equals ([ee64e99](ee64e99))
* **client:** partialDataPolicy for configuring rejections ([0a7cd28](0a7cd28))
* **client:** QueryResult.unexecuted ([13e3257](13e3257))
* **client:** refetchSafeQueries, clarify rebroadcast calls in docs ([e45b240](e45b240))
* **docs:** v4 changelog ([38cfd9b](38cfd9b))
* **examples:** reorg graphql example so pub displays code ([bc32bdd](bc32bdd))
* **examples:** starwars hivestore usage ([2f874ec](2f874ec))
* **graphql:** add isMutation etc helpers to Options types ([04e7888](04e7888))
* **graphql:** complete caching overhaul ([e9b5660](e9b5660))
* **graphql:** HiveStore api improvements, fetchmore fixes ([2d1a7f2](2d1a7f2))
* **graphql:** multipart file support ([c2733ca](c2733ca))
* **graphql:** re-add documentNode asdeprecated ([20d0176](20d0176))
* more work on gql links ([0d7ef7a](0d7ef7a))
* **graphql:** Robust ObservableQuery docs ([1e893b5](1e893b5))
* **graphql:** update old websocket_link ([496d994](496d994))
* **graphql:** upgrade normalize to 0.4.2 ([4655e7d](4655e7d))
* **graphql:** use new cache correctly everywhere else ([f64a6c8](f64a6c8))
* starting on gql links ([d9452bc](d9452bc))
* **graphql:** work on making subscriptions more of a first-class citizen ([6d0b045](6d0b045))
* **graphql_flutter:** add ResultAccumulator, fix Subscription ([7e1edee](7e1edee))
* **graphql_flutter:** initHiveForFlutter ([1118cc7](1118cc7))
* HiveStore ([2c3c66c](2c3c66c))
* move to DocumentNode-only documents ([7499323](7499323))
* **graphql_flutter:** work on making subscriptions more of a first-class citizen ([a0e0d5c](a0e0d5c))
* **tests:** test subscriptions ([2a3e6a1](2a3e6a1))

### BREAKING CHANGES

* **client:** By fixing the defaults for mutations, the old behavior
is now lost
* the deprecated string documents are no longer supported
* Link layer is now implemented via package:gql_link and package:gql_exec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micimize micimize

Labels
v4 Issue with a v4 library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@micimize @aseef17