fix(graphql): don't close mutations after callbacks

zino-hofmann · Jul 27, 2020 · 2ba6c74 · 2ba6c74
1 parent 76c8bf1
commit 2ba6c74
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/graphql/lib/src/core/observable_query.dart b/packages/graphql/lib/src/core/observable_query.dart
@@ -289,9 +289,9 @@ class ObservableQuery {
           lifecycle = QueryLifecycle.completed;
           close();
         }
+        // the mutation has been completed, but disposal has not been requested
         if (lifecycle == QueryLifecycle.sideEffectsPending) {
           lifecycle = QueryLifecycle.completed;
-          close();
         }
       }
     }

diff --git a/packages/graphql_flutter/lib/src/widgets/mutation.dart b/packages/graphql_flutter/lib/src/widgets/mutation.dart
@@ -102,8 +102,7 @@ class MutationState extends State<Mutation> {
     return (observableQuery
           ..variables = variables
           ..options.optimisticResult = optimisticResult
-          ..onData(mutationCallbacks
-              .callbacks) // add callbacks to observable // interesting
+          ..onData(mutationCallbacks.callbacks) // add callbacks to observable
         )
         .fetchResults();
   }