Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outgoing_tx_data.to_address should not carry UA #758

Open
AArnott opened this issue Dec 13, 2023 · 1 comment
Open

outgoing_tx_data.to_address should not carry UA #758

AArnott opened this issue Dec 13, 2023 · 1 comment

Comments

@AArnott
Copy link
Contributor

AArnott commented Dec 13, 2023

Why is zingolib providing the compound UA in the to_address field, leaving the recipient_ua field empty for a transaction's outgoing_tx_data? I expected the to_address to always be the literal address used in the transaction, and if Zingolib is going to preserve the UA's other receivers in the change memo, that that would only appear under recipient_ua

image

@AArnott
Copy link
Contributor Author

AArnott commented Dec 13, 2023

On matrix, altum suggested that the to_address is dropped on save and replaced with the value from recipient_ua. This is information lossy. It is not reconstructed on deserialization, and I'd argue cannot be, since the receiver that had previously been chosen cannot be reliably guessed from the many receivers in the UA later on, when perhaps zingolib supports more receiver types than it did when creating that transaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant