Implement new zigpy packet API #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue is on the firmware side as far as I remember.
You need to ask @fairecasoimeme
PS/ our plugin is not using zigpy-zigate because this is not controlling the flow and so create issue on Zigate.
|
|
@puddly the PR is posted nearly since a year but unfortunately not taken in consideration Anyhow Zigate is providing a direct API for Permit to join |
Collaborator
Author
It provides an API but the only effect I am seeing is it opening joins on the coordinator (i.e. the network beacon's Regardless, this is a ZiGate firmware problem, not something I can solve in software. |
|
If you use the ZiGap command, depending of the Mask this will broadcast to others or not. I'm using it even to open the network only from one network |
Drop 3.7 from CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once zigpy/zigpy#1043 is merged and a new zigpy version is released this PR can be merged.
Prior to this change, broadcast was not implemented in zigpy-zigate. It should be functional now that the correct address mode is implemented, but it is not: the packet is correctly sent with the appropriate address mode and a non-zero radius, but I cannot see it with a sniffer.
This has the unfortunate side effect of not allowing you to permit joins through any device other than the coordinator.
@pipiche38